From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=yKv8=5A=gnu.org=eliz@sourceware.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
	by sourceware.org (Postfix) with ESMTPS id 8F9E23858D1E
	for <gdb-patches@sourceware.org>; Tue,  3 Jan 2023 20:17:57 +0000 (GMT)
Received: from fencepost.gnu.org ([2001:470:142:3::e])
	by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <eliz@gnu.org>)
	id 1pCnjO-0000z4-Rd; Tue, 03 Jan 2023 15:17:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
	mime-version; bh=sttgWB+ZOoG37d+TjhCYcwNAJCCSn3T9OzlxQxqZg80=; b=FhJ9Jk3Ok9EL
	fsO8h2GAyCngQmbq/hcNJnZ81z/7o2C9VEN0CGuFTO3mEORkuVWuTf8aJA92PwHIEPj73YjDQkh/l
	2HB0c/TqTn7mvldBideu2RPnJJb0vZ2a0m4Fiq2J9IWpClOJMg6DbqWJKjJ6r48Rdls7iyvYNX/qw
	LKqMn7CD2V+B82XRf756p/+XBqL/OJjT/FVRMwEYBtzzzEntqgxjbflePuC43sOV24cZ5ODKNh21u
	Dv/EJPbNGG33LPezADOBOQJjH70OoyYTNGMdYmwsKOmUgktV/2ijGivxo7z1MySCzwpfF2H1te51M
	sGjV5jQXdi/dwkjp0IzBeQ==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <eliz@gnu.org>)
	id 1pCnjO-0005wZ-4M; Tue, 03 Jan 2023 15:17:54 -0500
Date: Tue, 03 Jan 2023 22:18:03 +0200
Message-Id: <83wn63z81w.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Christian Biesinger <cbiesinger@google.com>
Cc: simark@simark.ca, tom@tromey.com, gdb-patches@sourceware.org,
	luis.machado@arm.com
In-Reply-To:
	<CAPTJ0XGfDpAALz05-DsBsxCzkW1t+X==SEyGFWK9JmxW8VFx+A@mail.gmail.com>
	(message from Christian Biesinger on Tue, 3 Jan 2023 14:44:56 -0500)
Subject: Re: Two observations using GDB 13 snapshot
References: <83h6xugc5v.fsf@gnu.org> <58b64bf8-90b6-d080-c060-d03761501199@arm.com>
 <83k02neezy.fsf@gnu.org> <c32cb97c-a189-6860-d1f0-af77a564db58@arm.com>
 <835ye7e9jw.fsf@gnu.org> <87h6xrks77.fsf@tromey.com> <83mt7idacj.fsf@gnu.org>
 <87fsd4elb2.fsf@tromey.com> <83o7rs4qmg.fsf@gnu.org> <87cz84dasj.fsf@tromey.com>
 <835ydw20bw.fsf@gnu.org> <87wn6bbi5m.fsf@tromey.com> <83sfgz8m9i.fsf@gnu.org>
 <87o7rnb0ya.fsf@tromey.com> <83a6368chf.fsf@gnu.org> <87k02aaxc8.fsf@tromey.com>
 <83wn6a6n21.fsf@gnu.org> <587b899f-0f93-530a-7313-d4e1f9e501b9@simark.ca> <835ydt6jzw.fsf@gnu.org> <CAPTJ0XGfDpAALz05-DsBsxCzkW1t+X==SEyGFWK9JmxW8VFx+A@mail.gmail.com>
X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

> From: Christian Biesinger <cbiesinger@google.com>
> Date: Tue, 3 Jan 2023 14:44:56 -0500
> Cc: Simon Marchi <simark@simark.ca>, tom@tromey.com, gdb-patches@sourceware.org, 
> 	luis.machado@arm.com
> 
> > > https://stackoverflow.com/questions/36686381/windows-c-runtime-toupper-slow-when-locale-set
> > > https://bugs.php.net/bug.php?id=45265
> >
> > I couldn't see any numbers there about the performance of tolower
> > itself, i.e. how many ms per call does it take on Windows vs glibc.
> > But if someone can show a patch to try to eliminate the calls to
> > tolower, I can try and see if it affects the processing time in this
> > scenario.
> 
> Seems like that could be tested by running gdb with LANG=C and/or
> commenting out the setlocale calls in gdb/main.c?

Setting LANG in the environment doesn't have any effect on Windows,
since the Windows version of setlocale is insensitive to LANG and LC_*
environment variables.