From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92128 invoked by alias); 15 Jan 2020 16:07:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92109 invoked by uid 89); 15 Jan 2020 16:07:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Jan 2020 16:07:34 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1irlCe-00034I-Bf; Wed, 15 Jan 2020 11:07:32 -0500 Received: from [176.228.60.248] (port=2561 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1irlCY-0002oM-P7; Wed, 15 Jan 2020 11:07:30 -0500 Date: Wed, 15 Jan 2020 17:51:00 -0000 Message-Id: <83wo9s4sac.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <20200114210956.25115-3-tromey@adacore.com> (message from Tom Tromey on Tue, 14 Jan 2020 14:09:55 -0700) Subject: Re: [PATCH 2/3] Consistently use BFD's time References: <20200114210956.25115-1-tromey@adacore.com> <20200114210956.25115-3-tromey@adacore.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00422.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey > Date: Tue, 14 Jan 2020 14:09:55 -0700 > > gdb uses the gnulib stat, while BFD does not. This can lead to > inconsistencies between the two, because the gnulib stat adjusts for > timezones. There's one more potential issue with Gnulib's replacement of 'fstat': it also replaces the definition of 'struct stat', and it does that in a way that might yield incompatibility between the definition on the system header and Gnulib's sys/stat.h replacement. If gdb_bfd.c uses the Gnulib definition of 'struct stat' (as I think we do everywhere in gdb/), then this replacement might create problems on MinGW similar to those I reported to the Gnulib list (see the URL I cited in an earlier message), because bfd_stat uses an incompatible definition of 'struct stat'. Of course, given that the Gnulib developers rejected my request not to override the system definition of 'struct stat', GDB could also ignore those problems, accepting their judgment.