From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24046 invoked by alias); 28 Aug 2018 17:22:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24037 invoked by uid 89); 28 Aug 2018 17:22:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 17:22:57 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fuhhb-0003nI-UF for gdb-patches@sourceware.org; Tue, 28 Aug 2018 13:22:55 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fuhhY-0003kO-4F; Tue, 28 Aug 2018 13:22:49 -0400 Received: from [176.228.60.248] (port=1693 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fuhhX-0000OP-Gx; Tue, 28 Aug 2018 13:22:48 -0400 Date: Tue, 28 Aug 2018 17:22:00 -0000 Message-Id: <83wosa2yos.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: sizious@gmail.com, gdb-patches@sourceware.org In-reply-to: <18eaf339-ca0a-061c-4a17-b837e6ef81a2@redhat.com> (message from Pedro Alves on Tue, 28 Aug 2018 17:57:43 +0100) Subject: Re: [PATCH][PR build/23568] Fix gdb-7.12.1 MinGW/MSYS build issue References: <56c5911c-e0ba-5a17-64bb-3634af60a07d@gmail.com> <18eaf339-ca0a-061c-4a17-b837e6ef81a2@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00696.txt.bz2 > From: Pedro Alves > Date: Tue, 28 Aug 2018 17:57:43 +0100 > > On 08/28/2018 01:01 PM, SiZiOUS wrote: > > This little patch was made to allow the compilation under the MinGW/MSYS legacy environment (I don't know for the newer MinGW-w64/MSYS2 environment!). > > If this patch is not applied, then the compilation of gdb-7.12.1 under MinGW/MSYS is impossible. > > GDB 7.12 is old by now and not actively maintained. > > Can you check whether this is necessary on the master branch? AFAICS, we include winerror.h via serial.h, which includes winsock2.h, which includes winerror.h. Older MinGW included that via the chain windows.h->windef.h->winnt.h. SiZiOUS, what version of the MinGW runtime are you using?