public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Xavier Roirand <roirand@adacore.com>
Cc: gdb-patches@sourceware.org, simon.marchi@ericsson.com,
	brobecker@adacore.com
Subject: Re: [RFAv2] (Ada) Add gdb-mi support for stopping at start of exception handler.
Date: Mon, 08 Jan 2018 18:38:00 -0000	[thread overview]
Message-ID: <83wp0s6vsl.fsf@gnu.org> (raw)
In-Reply-To: <1515402878-30564-1-git-send-email-roirand@adacore.com> (message	from Xavier Roirand on Mon, 8 Jan 2018 10:14:38 +0100)

> From: Xavier Roirand <roirand@adacore.com>
> Cc: Xavier Roirand <roirand@adacore.com>,	simon.marchi@ericsson.com,	brobecker@adacore.com
> Date: Mon,  8 Jan 2018 10:14:38 +0100
> 
> Following my previous commit which add support for stopping at start of
> exception handler, this commit adds required gdb-mi support for this
> feature.
> 
> gdb/ChangeLog:
> 
>         * ada-lang.c (catch_ada_exception_command_split,
>         create_ada_exception_catchpoint, catch_ada_assert_command_split)
>         <cond_string>: Change parameter type.  Update code accordingly.
>         Update callers.
>         (catch_ada_exception_command, catch_ada_handlers_command,
>         catch_assert_command): Use std::string instead of char*.
>         * ada-lang.h (create_ada_exception_catchpoint) <cond_string>:
>         Update declaration.
>         * mi/mi-cmd-catch.c (mi_cmd_catch_assert): Use std::string
>         instead of char* for condition string.
>         (mi_cmd_catch_exception): Use std::string instead of char* for
>         condition string.  Remove uneeded xstrdup.
>         (mi_cmd_catch_handlers): New function for -catch-handlers command.
>         * mi/mi-cmds.c (struct mi_cmds): Add catch-handlers command.
>         * mi/mi-cmds.h (mi_cmd_catch_handlers): Add external declaration.
>         * NEWS: Document "-catch-handlers" command.
> 
> gdb/doc/ChangeLog:
> 
>         * gdb.texinfo (Ada Exception gdb/mi Catchpoints): Add
>         documentation for new "-catch-handlers" command.
> 
> gdb/testsuite/ChangeLog:
> 
>         * gdb.ada/mi_catch_ex_hand.exp: New testcase.
>         * gdb.ada/mi_catch_ex_hand/foo.adb: New file.

The documentation parts of this patch are approved, with this single
comment:

> +@subsubheading @value{GDBN} Command
> +
> +The corresponding @value{GDBN} command is @samp{catch handlers}.

Please add here a cross-reference to where "catch handlers" is
described.

Thanks.

  reply	other threads:[~2018-01-08 18:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08  9:15 Xavier Roirand
2018-01-08 18:38 ` Eli Zaretskii [this message]
2018-01-23 11:43 ` Joel Brobecker
2018-01-29 12:46   ` [PATCH 1/4] (Ada) Add testcase for catch assert with condition Xavier Roirand
2018-01-30  4:41     ` Joel Brobecker
2018-01-29 12:47   ` [PATCH 4/4] (Ada) Add gdb-mi support for stopping at start of exception handler Xavier Roirand
2018-01-29 15:57     ` Eli Zaretskii
2018-01-30  7:13     ` Joel Brobecker
2018-01-29 12:47   ` [PATCH 2/4] (Ada/MI) Add testcase for mi catch assert with condition Xavier Roirand
2018-01-30  4:49     ` Joel Brobecker
2018-01-29 12:47   ` [PATCH 3/4] (Ada) C++fy conditional string when catching exception Xavier Roirand
2018-01-30  4:57     ` Joel Brobecker
2018-01-30  9:23   ` [PATCH 2/4] (Ada/MI) Add testcase for mi catch assert with condition Xavier Roirand
2018-01-31  4:39     ` Joel Brobecker
2018-01-30  9:23   ` [PATCHv2 1/4] (Ada) Add testcase for " Xavier Roirand
2018-01-31  4:37     ` Joel Brobecker
2018-01-31 12:52       ` pushed: [PATCH " Xavier Roirand
2018-01-31 12:53       ` [PATCH 2/4] (Ada/MI) Add testcase for mi " Xavier Roirand
2018-01-31 12:53       ` [PATCH 3/4] (Ada) C++fy conditional string when catching exception Xavier Roirand
2018-01-31 12:54       ` pushed: [PATCH] (Ada) Add gdb-mi support for stopping at start of exception handler Xavier Roirand
2018-01-31 12:54       ` pushed: [PATCH 3/4] (Ada) C++fy conditional string when catching exception Xavier Roirand
2018-01-31 12:54       ` pushed: [PATCH 2/4] (Ada/MI) Add testcase for mi catch assert with condition Xavier Roirand
2018-01-31 13:03       ` pushed: [PATCH 4/4] (Ada) Add gdb-mi support for stopping at start of exception handler Xavier Roirand
2018-01-30  9:24   ` [PATCH 3/4] (Ada) C++fy conditional string when catching exception Xavier Roirand
2018-01-31  4:41     ` Joel Brobecker
2018-01-30  9:24   ` [PATCH 4/4] (Ada) Add gdb-mi support for stopping at start of exception handler Xavier Roirand
2018-01-31  4:45     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wp0s6vsl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=roirand@adacore.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).