From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44368 invoked by alias); 8 Jan 2018 18:38:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44326 invoked by uid 89); 8 Jan 2018 18:38:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Jan 2018 18:38:23 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYcJQ-0003mG-TF for gdb-patches@sourceware.org; Mon, 08 Jan 2018 13:38:21 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYcJJ-0003ih-Vq; Mon, 08 Jan 2018 13:38:14 -0500 Received: from [176.228.60.248] (port=3455 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eYcJJ-0001i4-Fr; Mon, 08 Jan 2018 13:38:13 -0500 Date: Mon, 08 Jan 2018 18:38:00 -0000 Message-Id: <83wp0s6vsl.fsf@gnu.org> From: Eli Zaretskii To: Xavier Roirand CC: gdb-patches@sourceware.org, simon.marchi@ericsson.com, brobecker@adacore.com In-reply-to: <1515402878-30564-1-git-send-email-roirand@adacore.com> (message from Xavier Roirand on Mon, 8 Jan 2018 10:14:38 +0100) Subject: Re: [RFAv2] (Ada) Add gdb-mi support for stopping at start of exception handler. Reply-to: Eli Zaretskii References: <1515402878-30564-1-git-send-email-roirand@adacore.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00168.txt.bz2 > From: Xavier Roirand > Cc: Xavier Roirand , simon.marchi@ericsson.com, brobecker@adacore.com > Date: Mon, 8 Jan 2018 10:14:38 +0100 > > Following my previous commit which add support for stopping at start of > exception handler, this commit adds required gdb-mi support for this > feature. > > gdb/ChangeLog: > > * ada-lang.c (catch_ada_exception_command_split, > create_ada_exception_catchpoint, catch_ada_assert_command_split) > : Change parameter type. Update code accordingly. > Update callers. > (catch_ada_exception_command, catch_ada_handlers_command, > catch_assert_command): Use std::string instead of char*. > * ada-lang.h (create_ada_exception_catchpoint) : > Update declaration. > * mi/mi-cmd-catch.c (mi_cmd_catch_assert): Use std::string > instead of char* for condition string. > (mi_cmd_catch_exception): Use std::string instead of char* for > condition string. Remove uneeded xstrdup. > (mi_cmd_catch_handlers): New function for -catch-handlers command. > * mi/mi-cmds.c (struct mi_cmds): Add catch-handlers command. > * mi/mi-cmds.h (mi_cmd_catch_handlers): Add external declaration. > * NEWS: Document "-catch-handlers" command. > > gdb/doc/ChangeLog: > > * gdb.texinfo (Ada Exception gdb/mi Catchpoints): Add > documentation for new "-catch-handlers" command. > > gdb/testsuite/ChangeLog: > > * gdb.ada/mi_catch_ex_hand.exp: New testcase. > * gdb.ada/mi_catch_ex_hand/foo.adb: New file. The documentation parts of this patch are approved, with this single comment: > +@subsubheading @value{GDBN} Command > + > +The corresponding @value{GDBN} command is @samp{catch handlers}. Please add here a cross-reference to where "catch handlers" is described. Thanks.