From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17652 invoked by alias); 30 Dec 2014 19:30:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17629 invoked by uid 89); 30 Dec 2014 19:30:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout21.012.net.il Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Dec 2014 19:30:21 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NHE00300U612Y00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Tue, 30 Dec 2014 21:30:18 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHE0027BU6HV580@a-mtaout21.012.net.il>; Tue, 30 Dec 2014 21:30:18 +0200 (IST) Date: Tue, 30 Dec 2014 19:30:00 -0000 From: Eli Zaretskii Subject: Re: File-name completer marks all files as executable on MS-Windows In-reply-to: <54A1A4A4.2070600@redhat.com> To: Pedro Alves Cc: chet.ramey@case.edu, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83wq599br3.fsf@gnu.org> References: <83egrklxde.fsf@gnu.org> <54A17585.5010900@case.edu> <83bnmmjuio.fsf@gnu.org> <54A1A4A4.2070600@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00687.txt.bz2 > Date: Mon, 29 Dec 2014 18:59:48 +0000 > From: Pedro Alves > CC: gdb-patches@sourceware.org > > On 12/29/2014 04:22 PM, Eli Zaretskii wrote: > >> Date: Mon, 29 Dec 2014 10:38:45 -0500 > >> From: Chet Ramey > >> CC: chet.ramey@case.edu, gdb-patches@sourceware.org > >> > >> On 12/27/14 2:13 PM, Eli Zaretskii wrote: > >>> I discovered that completing on file names in GDB on MS-Windows marks > >>> every file as executable. This is because Readline uses 'access' and > >>> X_OK to determine that, which doesn't work on Windows. > >> > >> Ugh, really? Thanks for the patch. > > > > Thanks for reviewing it. > > > > Joel, Pedro, others: can I now commit this to the GDB repository? > > Branch too? > > Fine with me. Thanks, done.