From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 11725385609B for ; Tue, 19 Sep 2023 11:27:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11725385609B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiYtQ-0000uQ-6V; Tue, 19 Sep 2023 07:27:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VXoksDDJh6wfdSfuCHgBLH7cuz/1YSZ2ZjOlYRqhiM0=; b=Xc/6OZ2XAciZ +pJyuwTpoTK7XTtkRugWyPTj6CVwpWKtmaXuE/K0XPsvo1a3JhisSTAvNLD0ldDLy7QIPn1Apr7iq kg9epcPaLJiWhc1nP0j4AuKhNs6RwuAfn3kcVjI1RnZGdBl1SpDhoSVkt4PG9jWqD3uM5S/yLLBgn F4WZjntUly2dpJBInB4v/y3CByDbcJ9/b9Seqv/jRhFYDl+ZO+WQfpGOMjQplQhQaVI2DyI1pIYuV s+zKU7R8d55CK7a5HDqGikKqtg5bB3gKICklE9yL6J89ykORv50uhLJRQgiyNVI9WtFnAA1qHQDZg nVxynZ6T3DF3oATkEgbtrQ==; Date: Tue, 19 Sep 2023 14:27:49 +0300 Message-Id: <83y1h2csi2.fsf@gnu.org> From: Eli Zaretskii To: Guinevere Larsen Cc: gdb-patches@sourceware.org, blarsen@redhat.com, aburgess@redhat.com In-Reply-To: <20230919090627.2580364-2-blarsen@redhat.com> (message from Guinevere Larsen on Tue, 19 Sep 2023 11:06:28 +0200) Subject: Re: [PATCH v4] gdb/cli: fixes to newly added "list ." command References: <20230828155039.120251-2-blarsen@redhat.com> <20230919090627.2580364-2-blarsen@redhat.com> X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Guinevere Larsen > Cc: eliz@gnu.org, > Guinevere Larsen , > Andrew Burgess > Date: Tue, 19 Sep 2023 11:06:28 +0200 > > After the series that added this command was pushed, Pedro mentioned > that the news description could easily be misinterpreted, as well as > some code and test improvements that should be made. > > While fixing the test, I realized that code repetition wasn't > happening as it should, so I took care of that too. Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index 98ff00d5efc..2837c62b163 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -90,8 +90,9 @@ > expression parser. > > * The 'list' command now accepts '.' as an argument, which tells GDB to > - print the location where the inferior is stopped. If the inferior hasn't > - started yet, the command will print around the main function. > + print the location around the point of execution within the current frame. > + If the inferior hasn't started yet, the command wil print around the > + beginning of the 'main' function. ^^^ Typo. > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -9212,9 +9212,9 @@ Same as using with no arguments. > Print lines just before the lines last printed. > > @item list . > -Print the lines surrounding the location that is where the inferior > -is stopped. If the inferior is not running, print around the main > -function instead. > +Print the lines surrounding the point of execution within the > +currently selected frame. If the inferior is not running print lines > +around the start of the main function instead. ^ A comma is missing there. Reviewed-By: Eli Zaretskii