From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id A29FE3858C00 for ; Mon, 11 Sep 2023 19:04:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A29FE3858C00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfmDQ-0005g6-0a; Mon, 11 Sep 2023 15:04:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=95yH1VwKfyGD9OSdT3FYs65bM3VpezrCE0KUoO1lUec=; b=DmcR5ZufKkV8 rE/J8Wz2C2M3PNOiE72ay079tqQo6LSWOp34l26/59e3pEQhJS+9dYNTTljohHWbY8pr57TxhPnvQ MIbnMkvkpHAPSbxbWEV9+AsYZ5x7vmkBu/d9Mz/9rIg3TqOu3NmRtA42OVDiycFSpjxHCxNhpoEov nVlTsjDp2/TAVFDDCVw51S/pcT8IB3t4M8/aGJVM+bwfGl4JqS21+EUeIv9VURZmml/r6SG6WfcC6 9EkfoOdba+OAzRWNbYcJpDQe4xP2jcY2fumGGZXO2C6FaN1OzlfMUTTtaAITTW2O3Y6HMCPdjn1c8 7KbskT+P5hwqNJWapPYTMA==; Date: Mon, 11 Sep 2023 22:04:36 +0300 Message-Id: <83y1hcpm4b.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20230911-pp-v2-v1-1-c4e0d40c8b63@adacore.com> (message from Tom Tromey via Gdb-patches on Mon, 11 Sep 2023 11:28:25 -0600) Subject: Re: [PATCH 1/2] Introduce gdb.ValuePrinter References: <20230911-pp-v2-v1-0-c4e0d40c8b63@adacore.com> <20230911-pp-v2-v1-1-c4e0d40c8b63@adacore.com> X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Mon, 11 Sep 2023 11:28:25 -0600 > From: Tom Tromey via Gdb-patches > > There was an earlier thread about adding new methods to > pretty-printers: Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index 98ff00d5efc..cca86d82de8 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -286,6 +286,11 @@ info main > might be array- or string-like, even if they do not have the > corresponding type code. > > + ** gdb.ValuePrinter is a new class that can be used as the base > + class for the result of applying a pretty-printer. As a base > + class, it signals to gdb that the printer may implement new > + pretty-printer methods. > + > *** Changes in GDB 13 This part is OK. > +To allow extensibility, @value{GDBN} provides the > +@code{gdb.ValuePrinter} base class. This class does not provide any > +attributes or behavior, but instead serves as a tag that can be > +recognized by @value{GDBN}. For such printers, @value{GDBN} reserves > +all attributes of starting with a lower-case letter. That is, in the I think that "of" should be removed. The python.texi part is OK otherwise. Reviewed-By: Eli Zaretskii