From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 0E4CD3858C54 for ; Fri, 12 May 2023 14:38:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E4CD3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxTuh-0003xa-F6; Fri, 12 May 2023 10:38:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=F3pmhD0cRWb36SSoVUhyL2l9crYOTq+tK3OosTY19fs=; b=IYSCZ1X/PAUj KrLVZlaUMl3EQJLuLryhzZ6Jk3X2U8AfFDu9GB/7FK0zHL52e6BT+FeG1WeBl22g+7SIgZMXiJFM4 T1cC6pnHAxXXul+HnDcTGgfP6xse4ro8Mt4flY+oqwqW2376NHCIqNY3DqXHRQGhbGw/oRbS+u5cW cDUthxK/FbTqVxGLEmmYzXZXki+yDlEi/7AqGMAyqw+a6ENhBK8gz1FCh8rr0cMMtSrmiSlm3GpTH C3i/ej5KjAwzQIglWF7j6XuGBPcURGhlzHZxrU2ue7yp8JxJuQpbhFy4yizM3cTc1fCaGogxswGRp t8bqNm8xKnGUkWa1QJOeXg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxTug-0002Wj-V7; Fri, 12 May 2023 10:38:31 -0400 Date: Fri, 12 May 2023 17:38:28 +0300 Message-Id: <83y1ltbonv.fsf@gnu.org> From: Eli Zaretskii To: Matti Puputti Cc: gdb-patches@sourceware.org, aburgess@redhat.com In-Reply-To: <20230512133320.1236624-2-matti.puputti@intel.com> (message from Matti Puputti on Fri, 12 May 2023 15:33:20 +0200) Subject: Re: [PATCH v5 1/1] gdb, infcmd: Support jump command with same line in multiple symtabs References: <20230512133320.1236624-1-matti.puputti@intel.com> <20230512133320.1236624-2-matti.puputti@intel.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Matti Puputti > Cc: eliz@gnu.org, > aburgess@redhat.com > Date: Fri, 12 May 2023 15:33:20 +0200 > > If a header file defining a static function is included in multiple source > files, each calling the function, and GDB is asked to jump to a line inside > that function, there would be multiple locations matching the target. The > solution in this commit is to select the location in the current symtab. > --- > gdb/doc/gdb.texinfo | 4 +- > gdb/infcmd.c | 14 ++++- > .../gdb.base/jump_multiple_objfiles-foo.c | 24 +++++++++ > .../gdb.base/jump_multiple_objfiles.c | 30 +++++++++++ > .../gdb.base/jump_multiple_objfiles.exp | 54 +++++++++++++++++++ > .../gdb.base/jump_multiple_objfiles.h | 30 +++++++++++ > 6 files changed, 154 insertions(+), 2 deletions(-) > create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles-foo.c > create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles.c > create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles.exp > create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles.h Thanks, the documentation part of this is OK. Reviewed-By: Eli Zaretskii