From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 58A15385800A for ; Tue, 4 Apr 2023 11:36:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58A15385800A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjexE-0002zt-MR; Tue, 04 Apr 2023 07:36:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Zib8C1tq0eMKNQGQFQ6eONQeb73ssGdjYL7CtiWNew4=; b=Bcv9RnLbqzbv RCnNaiZw7H1fOg7w6n8G/3kngk/GOQIunq9NXcJWN50hDQqGA5qT7IhHuTLdBbsr//0SvtlGHaxUN mIPeqb2x6tVlDk6brtzXzguHimZ+C7x7uFEhQlFi7Gwo6To9NW59JHUvQopviTTfyIAxhUcTdED39 ZnDGNG3AbbljRN8SHPg5J1qAdAOdGDo56mWixC8CifGqNik9Xn+mg0ZGWwE2dm/R2Y81vQQ73aKeB D0qR3oBaEAMbxmHVA3T2kin1vPTVTJdLecqBF7FXsnPz10QJ7Zx4C6F+6YzURQ+m1dmUK5moKIle6 qSVgkrX1dJliBEBPZ6jF1w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjexB-0007td-2y; Tue, 04 Apr 2023 07:35:59 -0400 Date: Tue, 04 Apr 2023 14:36:22 +0300 Message-Id: <83y1n7ubex.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: <3cdddabce2d5acfbdb9a8c5bdcb1a205a2bd01e5.1680596378.git.aburgess@redhat.com> (message from Andrew Burgess via Gdb-patches on Tue, 4 Apr 2023 09:21:03 +0100) Subject: Re: [PATCH 1/5] gdb/doc: improve Python Disassembler API documentation References: <3cdddabce2d5acfbdb9a8c5bdcb1a205a2bd01e5.1680596378.git.aburgess@redhat.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Andrew Burgess > Date: Tue, 4 Apr 2023 09:21:03 +0100 > From: Andrew Burgess via Gdb-patches > > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -6909,7 +6909,7 @@ > @code{RuntimeError} exception if it is invalid. > @end defun > > -@defun DisassembleInfo.__init__ (info) > +@defun DisassembleInfo.__init__ (@var{info}) You consistently rewrite the Texinfo source to use @var inside the argument lists of a @defun. I already asked why, as I don't think this is required. I don't think you replied. So once again: why are you doing this? what problems happen if you don't? Otherwise, this is fine. Thanks. Reviewed-By: Eli Zaretskii