From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id F03033858D37 for ; Tue, 14 Mar 2023 12:08:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F03033858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pc3S4-0000F0-VN; Tue, 14 Mar 2023 08:08:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=g9Z3/hvEMakkKcT7pVJMC+QQsUWk6hiRBF7/y5SXRgg=; b=hc3zXjA9QhKmaNMqa94+ SH8mOsrg+vKkLN9ZFrf6afJgkf535fFFaZjNKbICFdaNUP5XizhUmYMiIQCI/QdQEz6ts4SckdlwJ bUhpD8LyNVgsnT9jgKq+n7y3FjEb778BeTdaq1pAk0GzLGTwh0n0Wuof/u1J2jsm2wVkHNvDQadZu oVp3DetaLsL5Hb5BwZ3md19bBj9zN9DRZEdU23Aii2gew2/fEvtjmrG/LGYSzl4wWnqD7iO5Kp2rd aiULLFvbuNF4YtHxtpFLl+D1ZLdIfTIVPi6KOLryN9UdqsJZZKgOR4k+Mf3WfwGAilyh3iEHzxpiN /mTqUc9V9JRuBw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pc3S4-0001WA-60; Tue, 14 Mar 2023 08:08:24 -0400 Date: Tue, 14 Mar 2023 14:08:17 +0200 Message-Id: <83y1nzsfgu.fsf@gnu.org> From: Eli Zaretskii To: Philippe Blain Cc: gdb-patches@sourceware.org, apinski@marvell.com In-Reply-To: (message from Philippe Blain on Mon, 13 Mar 2023 12:45:04 -0400) Subject: Re: [PATCH 2/2] gdb/doc: uniformize wording for GMP and MPFR entries References: <20230306-doc-require-mpfr-fix-v1-0-8f207504dd3e@gmail.com> <20230306-doc-require-mpfr-fix-v1-2-8f207504dd3e@gmail.com> <83ttysxvp9.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: gdb-patches@sourceware.org, apinski@marvell.com > From: Philippe Blain > Date: Mon, 13 Mar 2023 12:45:04 -0400 > > Hi Eli, > > Le 2023-03-10 à 14:17, Eli Zaretskii a écrit : > >> Date: Fri, 10 Mar 2023 12:46:57 -0500 > >> Cc: Andrew Pinski > >> From: Philippe Blain via Gdb-patches > >> > >> Make the wording of the GMP and MPFR entries in the "Requirements for > >> Building GDB" section of the documentation more uniform by: > >> > >> - mentioning the configure script in the GMP entry, as is done in the > >> MPFR entry > >> - adding the long name of the MPFR library between parenthesis, as is > >> done in the GMP entry > >> - removing the second paragraph of the MPFR entry and moving its content > >> to the first one, mimicking the wording of the GMP entry > >> --- > >> gdb/doc/gdb.texinfo | 13 ++++++------- > >> 1 file changed, 6 insertions(+), 7 deletions(-) > > > > I don't mind the changes, but I also don't mind leaving the original > > text intact: there's nothing wrong with it per se. > > > > Thanks. > > > > Reviewed-By: Eli Zaretskii > > > > Thanks for the reviwew. I do not have push access, would you be so > kind as to push both patches ? My preference is to install only the first of these, for the reasons I explained, but I'm waiting to hear opinions of others, if they differ.