From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id 5B60E3858418
 for <gdb-patches@sourceware.org>; Mon, 28 Feb 2022 19:00:12 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B60E3858418
Received: from [2001:470:142:3::e] (port=46338 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nOlFj-0005NV-KE; Mon, 28 Feb 2022 14:00:11 -0500
Received: from [87.69.77.57] (port=2283 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nOlFh-0002TH-Fy; Mon, 28 Feb 2022 14:00:11 -0500
Date: Mon, 28 Feb 2022 20:59:59 +0200
Message-Id: <83y21ulsuo.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20220228183304.1162089-6-tromey@adacore.com> (message from Tom
 Tromey via Gdb-patches on Mon, 28 Feb 2022 11:33:04 -0700)
Subject: Re: [PATCH 5/5] Handle non-ASCII identifiers in Ada
References: <20220228183304.1162089-1-tromey@adacore.com>
 <20220228183304.1162089-6-tromey@adacore.com>
X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Feb 2022 19:00:17 -0000

> Date: Mon, 28 Feb 2022 11:33:04 -0700
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tromey@adacore.com>
> 
> +for c in range(0, 0x10FFFF):
> +    process_codepoint(c)

This script assumes that the version of Python which will run it is
up-to-date with the latest Unicode Character Database (UCD), right?
Is that a good assumption?  Wouldn't it be better to process the UCD
from the latest Unicode Standard directly?

> +@kindex set ada source-charset
> +Set the source character set for Ada.  The character set must be one
> +of the ones supported by GNAT.  Because this setting affects the

"must be one of the ones supported" sounds awkward.  Can you reword
it?

Other than that, the documentation parts are okay.  Thanks.