From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv2] gdb/python: add facility to add values into the history
Date: Wed, 25 Aug 2021 21:01:50 +0300 [thread overview]
Message-ID: <83y28ptnch.fsf@gnu.org> (raw)
In-Reply-To: <20210825172719.3814152-1-andrew.burgess@embecosm.com> (message from Andrew Burgess on Wed, 25 Aug 2021 18:27:19 +0100)
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 25 Aug 2021 18:27:19 +0100
>
> +* Python API
> +
> + ** New function gdb.add_history(), which takes a gdb.Value object
> + and adds the value to GDB's history list. An integer, the index
^^^^^^^^^
"its value", right?
> +@findex gdb.add_history
You don''t need @findex here, since @defun produces that
automatically.
> +Append @var{value}, an instance of @code{gdb.Value} (@pxref{Values
> +From Inferior}), to @value{GDBN}'s value history (@pxref{Value
This sounds like it appends the Python object to the history, but in
reality it appends its value, right?
> +History}) and return an integer, its history number. If @var{value}
^
Comma missing there.
Thanks.
next prev parent reply other threads:[~2021-08-25 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 8:48 [PATCH] " Andrew Burgess
2021-08-23 20:32 ` Tom Tromey
2021-08-25 17:27 ` [PATCHv2] " Andrew Burgess
2021-08-25 18:01 ` Eli Zaretskii [this message]
2021-08-26 9:20 ` Andrew Burgess
2021-08-26 9:40 ` Eli Zaretskii
2021-09-07 9:56 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y28ptnch.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).