From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 68440385B836
 for <gdb-patches@sourceware.org>; Wed, 25 Aug 2021 18:01:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 68440385B836
Received: from fencepost.gnu.org ([2001:470:142:3::e]:55210)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1mIxDk-000839-Kx; Wed, 25 Aug 2021 14:01:52 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2099
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1mIxDk-0005NH-3e; Wed, 25 Aug 2021 14:01:52 -0400
Date: Wed, 25 Aug 2021 21:01:50 +0300
Message-Id: <83y28ptnch.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20210825172719.3814152-1-andrew.burgess@embecosm.com> (message
 from Andrew Burgess on Wed, 25 Aug 2021 18:27:19 +0100)
Subject: Re: [PATCHv2] gdb/python: add facility to add values into the history
References: <874kbfaon0.fsf@tromey.com>
 <20210825172719.3814152-1-andrew.burgess@embecosm.com>
X-Spam-Status: No, score=2.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Aug 2021 18:01:55 -0000

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 25 Aug 2021 18:27:19 +0100
> 
> +* Python API
> +
> +  ** New function gdb.add_history(), which takes a gdb.Value object
> +     and adds the value to GDB's history list.  An integer, the index
                 ^^^^^^^^^
"its value", right?

> +@findex gdb.add_history

You don''t need @findex here, since @defun produces that
automatically.

> +Append @var{value}, an instance of @code{gdb.Value} (@pxref{Values
> +From Inferior}), to @value{GDBN}'s value history (@pxref{Value

This sounds like it appends the Python object to the history, but in
reality it appends its value, right?

> +History}) and return an integer, its history number.  If @var{value}
            ^
Comma missing there.

Thanks.