From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13562 invoked by alias); 11 Mar 2016 18:07:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13542 invoked by uid 89); 11 Mar 2016 18:07:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=D*linux.vnet.ibm.com, D*vnet.ibm.com, eliz@gnu.org, elizgnuorg X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 11 Mar 2016 18:07:20 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeRT4-00088N-07 for gdb-patches@sourceware.org; Fri, 11 Mar 2016 13:07:18 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeRT3-00088H-Sf; Fri, 11 Mar 2016 13:07:17 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3914 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aeRT2-0004AO-Rj; Fri, 11 Mar 2016 13:07:17 -0500 Date: Fri, 11 Mar 2016 18:07:00 -0000 Message-Id: <83y49oj3d2.fsf@gnu.org> From: Eli Zaretskii To: Andreas Arnez CC: palves@redhat.com, koriakin@0x04.net, gdb-patches@sourceware.org In-reply-to: (message from Andreas Arnez on Fri, 11 Mar 2016 17:45:16 +0100) Subject: Re: [PATCH 4/8] gdb/s390: Fill gen_return_address hook. Reply-to: Eli Zaretskii References: <1453637529-26972-5-git-send-email-koriakin@0x04.net> <1454853751-18455-1-git-send-email-koriakin@0x04.net> <56E2AD82.3060101@0x04.net> <56E2B95F.7050701@0x04.net> <56E2E7C8.7050901@redhat.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00196.txt.bz2 > From: Andreas Arnez > Cc: Eli Zaretskii > Cc: Marcin Kościelnicki , gdb-patches@sourceware.org > Date: Fri, 11 Mar 2016 17:45:16 +0100 > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 4ec0ec1..a14fe19 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -12863,7 +12863,9 @@ Collect all local variables. > > @item $_ret > Collect the return address. This is helpful if you want to see more > -of a backtrace. > +of a backtrace. Note that the return address can not always be > +determined reliably, and a wrong address may be collected instead. > +The reliability is usually higher for tracepoints at function entry. LGTM, thanks.