public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ken Werner <ken@linux.vnet.ibm.com>
Cc: brobecker@adacore.com, tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch] initial OpenCL C language support
Date: Thu, 04 Nov 2010 17:48:00 -0000	[thread overview]
Message-ID: <83y6993rqg.fsf@gnu.org> (raw)
In-Reply-To: <201011041638.46379.ken@linux.vnet.ibm.com>

> From: Ken Werner <ken@linux.vnet.ibm.com>
> Date: Thu, 4 Nov 2010 16:38:45 +0100
> Cc: Tom Tromey <tromey@redhat.com>, Eli Zaretskii <eliz@gnu.org>,
>         gdb-patches@sourceware.org
> 
> Attached is a patch that adds a few bits to the documentation and the NEWS 
> file.

Thanks.

> +by OpenCL 1.1.  In addition the half- and double-precision floating point
> +data types of the cl_khr_fp16 and cl_khr_fp64 OpenCL extensions are also
> +known to @value{GDBN}.

cl_khr_fp16 and cl_khr_fp64 should probably be in @code.

> +@value{GDBN} supports accesses to vector components including the access as
> +lvalue where possible. Since OpenCL C is based on C99 most C expressions
                        ^^
Two spaces, please.

> --- src.orig/gdb/NEWS	2010-11-04 14:14:25.000000000 +0100
> +++ src/gdb/NEWS	2010-11-04 14:18:33.000000000 +0100
> @@ -3,6 +3,9 @@
>  
>  *** Changes since GDB 7.2
>  
> +* OpenCL C
> +  Initial support for the OpenCL C language has been integrated into GDB.
> +

This part is fine, but I'd suggest to add a link to the OpenCL site
here.

Okay with those changes.

  reply	other threads:[~2010-11-04 17:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-22 17:21 Ken Werner
2010-10-25 22:41 ` Tom Tromey
2010-10-26 13:05   ` Ken Werner
2010-10-26 13:44     ` Tom Tromey
2010-10-26 16:02       ` Ken Werner
2010-10-26 17:49         ` Eli Zaretskii
2010-10-26 19:58         ` Joel Brobecker
2010-10-26 20:03           ` Joel Brobecker
2010-10-27 13:36             ` Ken Werner
2010-11-02 19:23               ` Joel Brobecker
2010-11-03 13:03                 ` Ken Werner
2010-11-03 15:27                   ` Joel Brobecker
2010-11-04 15:39                     ` Ken Werner
2010-11-04 17:48                       ` Eli Zaretskii [this message]
2010-11-05 14:21                         ` Ken Werner
2010-11-05 14:39                     ` Ken Werner
2010-10-27 19:04           ` Jan Kratochvil
2010-10-27 19:21             ` Pedro Alves
2010-10-27 21:01               ` Ken Werner
2010-11-02 16:52               ` [doc RFA] Switch to GCC coding style [Re: [patch] initial OpenCL C language support] Jan Kratochvil
2010-11-02 17:04                 ` Doug Evans
2010-11-02 17:23                   ` Jan Kratochvil
2010-11-02 17:29                     ` Doug Evans
2010-11-02 19:21                     ` Eli Zaretskii
2010-11-02 19:29                       ` Joel Brobecker
2010-11-08 12:50                       ` Jan Kratochvil
2010-11-08 16:11                         ` Joel Brobecker
2010-11-08 16:38                           ` Mark Kettenis
2010-11-08 16:43                             ` Joel Brobecker
2010-11-08 16:54                             ` Pedro Alves
2010-11-08 18:36                               ` Joel Brobecker
2010-11-02 18:01                   ` Joel Brobecker
2010-11-02 18:10                     ` [doc RFA] Switch to GCC coding style Jan Kratochvil
2010-11-02 18:20                       ` Doug Evans
2010-11-02 18:58                         ` Joel Brobecker
2010-11-02 19:19                           ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y6993rqg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ken@linux.vnet.ibm.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).