From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76331-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13409 invoked by alias); 4 Nov 2010 17:48:38 -0000
Received: (qmail 13382 invoked by uid 22791); 4 Nov 2010 17:48:36 -0000
X-SWARE-Spam-Status: No, hits=0.2 required=5.0	tests=AWL,BAYES_40,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Nov 2010 17:48:29 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LBD00200G0EKA00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 04 Nov 2010 19:48:04 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.249.126]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LBD000Q9G428YK0@a-mtaout20.012.net.il>; Thu, 04 Nov 2010 19:48:04 +0200 (IST)
Date: Thu, 04 Nov 2010 17:48:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] initial OpenCL C language support
In-reply-to: <201011041638.46379.ken@linux.vnet.ibm.com>
To: Ken Werner <ken@linux.vnet.ibm.com>
Cc: brobecker@adacore.com, tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83y6993rqg.fsf@gnu.org>
References: <201010221920.30046.ken@linux.vnet.ibm.com> <201011031402.40132.ken@linux.vnet.ibm.com> <20101103152723.GA2445@adacore.com> <201011041638.46379.ken@linux.vnet.ibm.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00088.txt.bz2

> From: Ken Werner <ken@linux.vnet.ibm.com>
> Date: Thu, 4 Nov 2010 16:38:45 +0100
> Cc: Tom Tromey <tromey@redhat.com>, Eli Zaretskii <eliz@gnu.org>,
>         gdb-patches@sourceware.org
> 
> Attached is a patch that adds a few bits to the documentation and the NEWS 
> file.

Thanks.

> +by OpenCL 1.1.  In addition the half- and double-precision floating point
> +data types of the cl_khr_fp16 and cl_khr_fp64 OpenCL extensions are also
> +known to @value{GDBN}.

cl_khr_fp16 and cl_khr_fp64 should probably be in @code.

> +@value{GDBN} supports accesses to vector components including the access as
> +lvalue where possible. Since OpenCL C is based on C99 most C expressions
                        ^^
Two spaces, please.

> --- src.orig/gdb/NEWS	2010-11-04 14:14:25.000000000 +0100
> +++ src/gdb/NEWS	2010-11-04 14:18:33.000000000 +0100
> @@ -3,6 +3,9 @@
>  
>  *** Changes since GDB 7.2
>  
> +* OpenCL C
> +  Initial support for the OpenCL C language has been integrated into GDB.
> +

This part is fine, but I'd suggest to add a link to the OpenCL site
here.

Okay with those changes.