From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1A8E23858D3C for ; Wed, 24 May 2023 16:55:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A8E23858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1rm6-0001HJ-Ny; Wed, 24 May 2023 12:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=POPcvHZALr7mwiy7Kts1pRd8ZWoh0hrpsaGhibtJnvk=; b=GuvLv8AzLYfa aKHgavvP0103zcWo9z92xzpcc7B06MPxazat0G9Kvtu/kQLC3t8y6gsS6kwFVx+PNpjE0LgxxdQnK sGlKubx+s/192rmGZE+j66oacr3opVuas5p+r1eifjTz37iMp8w1yZzTvRLdygD3HhrvjrJohC7YP JiIpE9kTfXd6KQ8dc5CauIBkWH3a+dnJqnUEeNtAz9MQS8v6lciuRfvUakWKNGZAKf76PpawUhULA BmTTa5mhT3pea+ofzOliUdonIGgMvGlPISRCGkzw87xYyWDS4isJGvXn0jJI7VMpGuIIhkY+h3xaF egR7t+ssyujzwE4PfElcGA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1rlT-0006Tq-OY; Wed, 24 May 2023 12:55:30 -0400 Date: Wed, 24 May 2023 19:55:36 +0300 Message-Id: <83zg5tmzxz.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20230427-ada-catch-exception-v1-21-947caa9905e3@adacore.com> (message from Tom Tromey via Gdb-patches on Wed, 24 May 2023 10:37:12 -0600) Subject: Re: [PATCH 21/25] Add "target" parameter to DAP attach request References: <20230427-ada-catch-exception-v1-0-947caa9905e3@adacore.com> <20230427-ada-catch-exception-v1-21-947caa9905e3@adacore.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Wed, 24 May 2023 10:37:12 -0600 > From: Tom Tromey via Gdb-patches > > This adds a new "target" to the DAP attach request. This is passed to > "target remote". I thought "attach" made the most sense for this, > because in some sense gdb is attaching to a running process. It's > worth noting that all DAP "attach" parameters are defined by the > implementation. > --- > gdb/doc/gdb.texinfo | 8 ++++-- > gdb/python/lib/gdb/dap/launch.py | 10 ++++++-- > gdb/testsuite/gdb.dap/remote-dap.exp | 49 ++++++++++++++++++++++++++++++++++++ > gdb/testsuite/lib/dap-support.exp | 11 ++++++++ > 4 files changed, 74 insertions(+), 4 deletions(-) Thanks, the documentation part is okay. Reviewed-By: Eli Zaretskii