From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 19E823858D37 for ; Tue, 9 May 2023 16:09:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19E823858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwPuM-0002YQ-Qp; Tue, 09 May 2023 12:09:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=w+akHUvOqvVU1jwKol2ymn0eIk1mALcfqD8/hWsokyA=; b=cg5kz7as/DQd oXoFnzKBJAqA9c5gSFYITguDxvwjHhM7392OSophzYHgi2pC2z5qGLnx0oGAooBeMD9NSUzp6M7lQ CcPH2yQIUYOkwqiJf7Lw0euqbRB4vasArzSfE1Y/Fbg7uTKAElW7SXYtXlQung/+aQn+1MwHu0Ois SmCCWuho1vxmW5sMRao4GgIMLoW3Uq9X9aryWzq/Kdx8V+LlAKsH07IOmf7vBoWwb19rnCOKAMV7B PcNaeog/j/4z5KatC+vw54GjftZ6mAhOuPTOXvMOjSOD0rjCQRrsJvPgwgRIz9PNPXhiDvEImlABl 4O+Gr0ltGyVGfTYi0w3BMQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwPuL-0000BU-Vz; Tue, 09 May 2023 12:09:46 -0400 Date: Tue, 09 May 2023 19:10:50 +0300 Message-Id: <83zg6da3jp.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20230509-dap-args-v1-2-16b5f0aa5cd6@adacore.com> (message from Tom Tromey via Gdb-patches on Tue, 09 May 2023 10:02:00 -0600) Subject: Re: [PATCH 2/2] Add "args" and "env" parameters to DAP launch request References: <20230509-dap-args-v1-0-16b5f0aa5cd6@adacore.com> <20230509-dap-args-v1-2-16b5f0aa5cd6@adacore.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Tue, 09 May 2023 10:02:00 -0600 > From: Tom Tromey via Gdb-patches > > This patch augments the DAP launch request with some optional new > parameters that let the client control the command-line arguments and > the environment of the inferior. > --- > gdb/doc/gdb.texinfo | 13 +++++- > gdb/python/lib/gdb/dap/launch.py | 20 ++++++++- > gdb/testsuite/gdb.dap/args-env.c | 28 ++++++++++++ > gdb/testsuite/gdb.dap/args-env.exp | 90 ++++++++++++++++++++++++++++++++++++++ > gdb/testsuite/lib/dap-support.exp | 39 +++++++++++++---- > 5 files changed, 178 insertions(+), 12 deletions(-) Thanks. > +@item env > +If provided, this should be an object where each value is a string. This doesn't say what should those string values be. Shouldn't they be of the format "@var{variable}=@var{value}"? > +The environment of the inferior will be set to exactly as passed in, > +as if by a sequence of invocations of @code{set environment} and > +@code{unset environment}. @xref{Environment}. This could potentially confuse: if this is equivalent to "set environment", then the variables are _added_ to the one inherited from the parent process, no? Also, when would this be equivalent to "unset environment"? Reviewed-By: Eli Zaretskii