From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 246643858D32 for ; Fri, 10 Mar 2023 15:38:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 246643858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paepc-0006xf-Kp; Fri, 10 Mar 2023 10:38:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j5XEybHqgmU5+gnITN+2/gvBMGIyaxryTGecDuCvc6k=; b=HvS0Zg7HecCn r2sOu+mOM9PFMiDH7dNKuPpYFNkYR+CXvXHWInwCbqZ9/SHaG98svFkxNqtURVftRgmA+UvbM79ni 0su0v0XbdZLnOoiZT9iN+isRToeEeawzmpsGFZ6plEoNTgjlHLS8IVQUip3gfYYv2Is/wUlkx3rqD mPV388Hkhwqjb2HFk1GmHB3pHzH7aRQIYyqbTxswNvG2PcA64lDOC7o1s9QgbVuGA8ulDCGnYRzIX /fY2mHSao/8bjnfdJdvPJDT5votyCZrzV9rwcTAEwSAg7laa3A9DLaDbCnBJfRyiCbEoZ1Q7yGZhE bv2hCQygbf62VyZ2vXAfzw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paepb-0007HE-LK; Fri, 10 Mar 2023 10:38:55 -0500 Date: Fri, 10 Mar 2023 17:38:38 +0200 Message-Id: <83zg8ky5tt.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: <9da6361cc56f184b6a44b1086d9fbeae6d30eab9.1678460067.git.aburgess@redhat.com> (message from Andrew Burgess via Gdb-patches on Fri, 10 Mar 2023 14:55:26 +0000) Subject: Re: [PATCH 09/10] gdb/python: Allow gdb.UnwindInfo to be created with non gdb.Value args References: <9da6361cc56f184b6a44b1086d9fbeae6d30eab9.1678460067.git.aburgess@redhat.com> X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Andrew Burgess > Date: Fri, 10 Mar 2023 14:55:26 +0000 > From: Andrew Burgess via Gdb-patches > > gdb/NEWS | 4 + > gdb/doc/python.texi | 3 +- > gdb/python/py-unwind.c | 113 ++++++++++++++----------- > gdb/testsuite/gdb.python/py-unwind.exp | 36 ++++++++ > gdb/testsuite/gdb.python/py-unwind.py | 6 +- > 5 files changed, 111 insertions(+), 51 deletions(-) > > diff --git a/gdb/NEWS b/gdb/NEWS > index 0d9049ff134..c4f7de11c6e 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -130,6 +130,10 @@ show always-read-ctf > - gdb.PendingFrame.function(): Return a gdb.Symbol for the > current pending frame, or None. > > + ** The frame-id passed to gdb.PendingFrame.create_unwind_info can > + now use either an integer or a gdb.Value object for each of its > + 'sp', 'pc', and 'special' attributes. > + > *** Changes in GDB 13 > > * MI version 1 is deprecated, and will be removed in GDB 14. > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi > index 1c4239841af..3074b5250a3 100644 > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -2815,7 +2815,8 @@ > this. > @end table > > -Each attribute value should be an instance of @code{gdb.Value}. > +Each attribute value should either be an instance of @code{gdb.Value} > +or an integer. > > @end defun OK for the documentation parts, thanks. Reviewed-By: Eli Zaretskii