From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 0E4CB395B457 for ; Wed, 9 Jun 2021 13:05:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0E4CB395B457 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42344) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqxtm-0006Ws-L8; Wed, 09 Jun 2021 09:05:34 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2083 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqxtm-0006Yz-97; Wed, 09 Jun 2021 09:05:34 -0400 Date: Wed, 09 Jun 2021 16:05:18 +0300 Message-Id: <83zgvzcho1.fsf@gnu.org> From: Eli Zaretskii To: Vasili Burdo Cc: gdb-patches@sourceware.org In-Reply-To: (message from Vasili Burdo on Wed, 9 Jun 2021 15:56:38 +0300) Subject: Re: [PATCH] TUI disassembly window improvemenmt References: <831r9bdxpj.fsf@gnu.org> X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 13:05:38 -0000 > From: Vasili Burdo > Date: Wed, 9 Jun 2021 15:56:38 +0300 > Cc: gdb-patches@sourceware.org > > > Shouldn't this be optional behavior? Not everyone disassembles only > > C++ code. > This patch does not limit disassembly view in any way. > - The current function name moved from disassembly line to window header > - Offset from function start still present in disassembly line > - Function start is marked by function name label. But AFAIU only the current function's name is visible; if some other function is referenced in the disassembly, it will now be invisible, right? IOW, you seem to assume that any function names mentioned in the disassembly are always the name of the current function, but is that an assumption that is always correct?