From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155069-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13149 invoked by alias); 30 Mar 2019 07:15:02 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 13115 invoked by uid 89); 30 Mar 2019 07:15:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS,URIBL_BLOCKED autolearn=ham version=3.3.1 spammy=
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 30 Mar 2019 07:15:00 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:35332)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1hA8Cg-0006W9-GD; Sat, 30 Mar 2019 03:14:58 -0400
Received: from [176.228.60.248] (port=3234 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1hA8Cf-00064E-RU; Sat, 30 Mar 2019 03:14:58 -0400
Date: Sat, 30 Mar 2019 07:15:00 -0000
Message-Id: <83zhpcj0ju.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
CC: gdb-patches@sourceware.org, Richard.Bunt@arm.com
In-reply-to: <20190329224116.GI10887@embecosm.com> (message from Andrew	Burgess on Fri, 29 Mar 2019 22:41:16 +0000)
Subject: Re: [PATCH 1/8] gdb: Add $_cimag and $_creal internal functions
References: <cover.1552913183.git.andrew.burgess@embecosm.com> <cover.1552913183.git.andrew.burgess@embecosm.com> <854230b716fa6838bd2d8e73f1fd2d342a7a75ed.1552913183.git.andrew.burgess@embecosm.com> <83va0gumjp.fsf@gnu.org> <20190329224116.GI10887@embecosm.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-03/txt/msg00757.txt.bz2

> Date: Fri, 29 Mar 2019 22:41:16 +0000
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: gdb-patches@sourceware.org, Richard.Bunt@arm.com
> 
> What I've done is group the @item entries for $_creal and $_cimag
> together.  My thinking is that if a user looks up either of these then
> the documentation should be complete.  If I left the @item entries
> separate, and removed the sentence as you suggested then I think I'd
> have to add a cross reference.
> 
> Hopefully this will be OK.

I have only one comment:

> +@item $_cimag(@var{value})
> +@item $_creal(@var{value})

The second @item should be @itemx.

Thanks.