From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: Allow parenthesis to group arguments to user-defined commands
Date: Wed, 15 Aug 2018 18:24:00 -0000 [thread overview]
Message-ID: <83zhxnirav.fsf@gnu.org> (raw)
In-Reply-To: <eaa6d3a2975194a7ef3a2aa40e335c7986b205d8.1534343840.git.andrew.burgess@embecosm.com> (message from Andrew Burgess on Wed, 15 Aug 2018 15:39:20 +0100)
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 15 Aug 2018 15:39:20 +0100
>
> When calling a user-defined command then currently, arguments are
> whitespace separated. This means that it is impossible to pass a
> single argument that contains a whitespace.
>
> The exception to the no whitespace rule is strings, a string argument,
> enclosed in double, or single quotes, can contain whitespace.
>
> However, if a user wants to reference, for example, a type name that
> contains a space, as in these examples:
>
> user_command *((unsigned long long *) some_pointer)
>
> user_command {unsigned long long}some_pointer
>
> then this will not work, as the whitespace between 'unsigned' and
> 'long', as well as the whitespace between 'long' and 'long', will mean
> GDB interprets this as many arguments.
>
> The solution proposed in this patch is to allow parenthesis to be used
> to group arguments, so the use could now write:
>
> user_command (*((unsigned long long *) some_pointer))
>
> user_command ({unsigned long long}some_pointer)
>
> And GDB will interpret these as a single argument.
>
> gdb/ChangeLog:
>
> * cli/cli-script.c (user_args::user_args): Allow parenthesis to
> group arguments.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/commands.exp (args_with_whitespace): New proc, which is
> added to the list of procs to call.
> * gdb.base/run.c (global_var): Defined global.
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (Define): Additional documentation about argument
> syntax.
> ---
> gdb/ChangeLog | 5 ++++
> gdb/cli/cli-script.c | 8 +++++-
> gdb/doc/ChangeLog | 5 ++++
> gdb/doc/gdb.texinfo | 54 +++++++++++++++++++++++++++++++++----
> gdb/testsuite/ChangeLog | 6 +++++
> gdb/testsuite/gdb.base/commands.exp | 36 +++++++++++++++++++++++++
> gdb/testsuite/gdb.base/run.c | 3 +++
> 7 files changed, 111 insertions(+), 6 deletions(-)
OK for the documentation parts.
Thanks.
next prev parent reply other threads:[~2018-08-15 18:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 14:39 [PATCH 0/2] " Andrew Burgess
2018-08-15 14:39 ` [PATCH 1/2] gdb: Make testnames unique in gdb.base/commands.exp Andrew Burgess
2018-08-30 15:26 ` Tom Tromey
2018-08-15 14:39 ` [PATCH 2/2] gdb: Allow parenthesis to group arguments to user-defined commands Andrew Burgess
2018-08-15 18:24 ` Eli Zaretskii [this message]
2018-08-25 19:32 ` Philippe Waroquiers
2018-08-25 20:53 ` Philippe Waroquiers
2018-08-25 22:43 ` Andrew Burgess
2018-08-28 15:54 ` Tom Tromey
2018-08-28 18:43 ` Andrew Burgess
2018-08-28 20:29 ` Philippe Waroquiers
2018-08-28 23:29 ` Andrew Burgess
2018-08-30 2:19 ` Tom Tromey
2018-08-30 21:19 ` Philippe Waroquiers
2018-08-31 20:59 ` Tom Tromey
2018-09-01 11:10 ` Philippe Waroquiers
2018-09-01 14:20 ` Tom Tromey
2018-09-01 15:36 ` Philippe Waroquiers
2018-08-30 2:26 ` Tom Tromey
2018-09-06 23:29 ` [PATCHv2] gdb: Rewrite argument handling for " Andrew Burgess
2018-09-07 6:31 ` Eli Zaretskii
2018-09-07 20:36 ` Tom Tromey
2018-09-07 22:47 ` Andrew Burgess
2018-09-08 6:27 ` Eli Zaretskii
2018-09-08 5:35 ` Philippe Waroquiers
2018-09-08 14:33 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zhxnirav.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).