public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Add --enable-codesign to gdb's configure
Date: Thu, 28 Jun 2018 18:31:00 -0000	[thread overview]
Message-ID: <83zhzeoja4.fsf@gnu.org> (raw)
In-Reply-To: <20180628163745.12716-1-tom@tromey.com> (message from Tom Tromey	on Thu, 28 Jun 2018 10:37:45 -0600)

> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Thu, 28 Jun 2018 10:37:45 -0600
> 
> macOS requires that the gdb executable be signed in order to be able
> to successfully use ptrace.  This must be done after each link.
> 
> This patch adds a new --enable-codesign configure option so that this
> step can be automated.
> 
> gdb/ChangeLog
> 2018-06-28  Tom Tromey  <tom@tromey.com>
> 
> 	* NEWS: Mention --enable-codesign.
> 	* silent-rules.mk (ECHO_SIGN): New variable.
> 	* configure.ac: Add --enable-codesign.
> 	* configure: Rebuild.
> 	* Makefile.in (CODESIGN, CODESIGN_CERT): New variables.
> 	(gdb$(EXEEXT)): Optionally invoke codesign.
> ---
>  gdb/ChangeLog       |  9 +++++++++
>  gdb/Makefile.in     |  7 +++++++
>  gdb/NEWS            |  7 +++++++
>  gdb/configure       | 11 +++++++++++
>  gdb/configure.ac    |  7 +++++++
>  gdb/silent-rules.mk |  1 +
>  6 files changed, 42 insertions(+)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index a125b72e420..08271641370 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,12 @@
> +2018-06-28  Tom Tromey  <tom@tromey.com>
> +
> +	* NEWS: Mention --enable-codesign.
> +	* silent-rules.mk (ECHO_SIGN): New variable.
> +	* configure.ac: Add --enable-codesign.
> +	* configure: Rebuild.
> +	* Makefile.in (CODESIGN, CODESIGN_CERT): New variables.
> +	(gdb$(EXEEXT)): Optionally invoke codesign.
> +
>  2018-06-27  Tom Tromey  <tom@tromey.com>

OK for the NEWS part, but I think we should reflect this option in the
output of "gdb --configure", because users will want to know whether
their GDB was configured that way.

Thanks.

  parent reply	other threads:[~2018-06-28 18:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 16:37 Tom Tromey
2018-06-28 17:31 ` Joel Brobecker
2018-06-28 18:31 ` Eli Zaretskii [this message]
2018-06-28 19:20   ` Joel Brobecker
2018-06-28 21:12     ` Tom Tromey
2018-06-29 22:19       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zhzeoja4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).