From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-147127-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31291 invoked by alias); 4 May 2018 20:20:45 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 31281 invoked by uid 89); 4 May 2018 20:20:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:632
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 May 2018 20:20:43 +0000
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1fEhC1-0003BB-1Q	for gdb-patches@sourceware.org; Fri, 04 May 2018 16:20:41 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50955)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1fEhC0-0003B7-TJ; Fri, 04 May 2018 16:20:36 -0400
Received: from [176.228.60.248] (port=2030 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1fEhC0-0008G1-AB; Fri, 04 May 2018 16:20:36 -0400
Date: Fri, 04 May 2018 20:20:00 -0000
Message-Id: <83zi1frx4c.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
CC: gdb-patches@sourceware.org
In-reply-to: <1525458603-33351-4-git-send-email-brobecker@adacore.com>	(message from Joel Brobecker on Fri, 4 May 2018 14:30:03 -0400)
Subject: Re: [PATCH 3/3] gdbserver/Windows: crash during connection establishment phase
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <1525458603-33351-1-git-send-email-brobecker@adacore.com> <1525458603-33351-4-git-send-email-brobecker@adacore.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-IsSubscribed: yes
X-SW-Source: 2018-05/txt/msg00145.txt.bz2

> From: Joel Brobecker <brobecker@adacore.com>
> Date: Fri,  4 May 2018 14:30:03 -0400
> 
> +#ifndef IN_PROCESS_AGENT
> +#ifdef __x86_64__
> +  static const char *expedite_regs_amd64[] = { "rbp", "rsp", "rip", NULL };
> +  tdesc->expedite_regs = expedite_regs_amd64;
> +#else /* __x86_64__ */

I believe the comment here should say /* !__x86_64__ */

> +  static const char *expedite_regs_i386[] = { "ebp", "esp", "eip", NULL };
> +  tdesc->expedite_regs = expedite_regs_i386;
> +#endif /* __x86_64__ */

Likewise here.

(Yes, nit-picking, I know.)

Thanks.