From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31157 invoked by alias); 3 Mar 2018 07:40:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31145 invoked by uid 89); 3 Mar 2018 07:40:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 03 Mar 2018 07:40:34 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1es1mS-0002w9-1b for gdb-patches@sourceware.org; Sat, 03 Mar 2018 02:40:32 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1es1mN-0002vT-Eh; Sat, 03 Mar 2018 02:40:27 -0500 Received: from [176.228.60.248] (port=4071 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1es1mM-00078I-Rx; Sat, 03 Mar 2018 02:40:27 -0500 Date: Sat, 03 Mar 2018 07:40:00 -0000 Message-Id: <83zi3pvc78.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess CC: gdb-patches@sourceware.org, simark@simark.ca In-reply-to: <430dd07a2ed6520ad17108eb156935ec86cec826.1520021226.git.andrew.burgess@embecosm.com> (message from Andrew Burgess on Fri, 2 Mar 2018 20:09:49 +0000) Subject: Re: [PATCHv3 2/2] gdb: Initial baremetal riscv support Reply-to: Eli Zaretskii References: <1b9ec42a-a0fd-667b-59a5-780e84cce451@simark.ca> <430dd07a2ed6520ad17108eb156935ec86cec826.1520021226.git.andrew.burgess@embecosm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00089.txt.bz2 > From: Andrew Burgess > Cc: Simon Marchi , > Eli Zaretskii , > Andrew Burgess > Date: Fri, 2 Mar 2018 20:09:49 +0000 > > This commit introduces basic support for baremetal RiscV as a GDB > target. This target is currently only tested against the RiscV software > simulator, which is not included as part of this commit. The target has > been tested against the following RiscV variants: rv32im, rv32imc, > rv32imf, rv32imfc, rv64im, rv64imc, rv64imfd, rv64imfdc. > > Across these variants we pass on average 34858 tests, and fail 272 > tests, which is ~0.8%. > > The RiscV has a feature of its ABI where structures with a single > floating point field, a single complex float field, or one float and one > integer field are treated differently for argument passing. The new > test gdb.base/nested-structs.exp is added to cover this feature. As > passing these structures should work on all targets then I've made the > test as a generic one, even though, for most targets, there's probably > nothing special about any of these cases. > > gdb/ChangeLog: > > * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o > (HFILES_NO_SRCDIR): Add riscv-tdep.h. > (ALLDEPFILES): Add riscv-tdep.c > * configure.tgt: Add riscv support. > * riscv-tdep.c: New file. > * riscv-tdep.h: New file. > * NEWS: Mention new target. > * MAINTAINERS: Add entry for riscv. > > gdb/testsuite/ChangeLog: > > * gdb.base/nested-structs.exp: New file. > * gdb.base/nested-structs.c: New file. > * gdb.base/float.exp: Add riscv support. The documentation part is OK. Thanks.