From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118331 invoked by alias); 4 Dec 2017 15:41:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118275 invoked by uid 89); 4 Dec 2017 15:41:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Dec 2017 15:41:03 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLsrZ-000706-Om for gdb-patches@sourceware.org; Mon, 04 Dec 2017 10:41:01 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLsrK-0006nB-CK; Mon, 04 Dec 2017 10:40:42 -0500 Received: from [176.228.60.248] (port=4266 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eLsrJ-0004o0-QE; Mon, 04 Dec 2017 10:40:42 -0500 Date: Mon, 04 Dec 2017 15:41:00 -0000 Message-Id: <83zi6yy00h.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: gdb-patches@sourceware.org, tom@tromey.com In-reply-to: <871ska7cx9.fsf@redhat.com> (message from Sergio Durigan Junior on Mon, 04 Dec 2017 10:03:46 -0500) Subject: Re: [PATCH v2] Implement pahole-like 'ptype /o' option Reply-to: Eli Zaretskii References: <20171121160709.23248-1-sergiodj@redhat.com> <20171128212137.15655-1-sergiodj@redhat.com> <871ska7cx9.fsf@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00078.txt.bz2 > From: Sergio Durigan Junior > Cc: Tom Tromey , Eli Zaretskii > Date: Mon, 04 Dec 2017 10:03:46 -0500 > > On Tuesday, November 28 2017, I wrote: > > > Changes from v1: > > > > - Address Tom's comments (the command now prints offset information > > about unions, and the offset info is carried on for nested structs). > > > > - Address Eli's comments. > > > > - Extended testcase. > > > > - A "bit" of cleanup on 'c_type_print_base'. > > Ping. I believe I already approved the documentation parts. Right?