Re: [PATCH V4 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls.

[Eli Zaretskii <eliz@gnu.org>]

> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Cc: gdb-patches@sourceware.org, Walfred Tedeschi <walfred.tedeschi@intel.com>
> Date: Wed,  2 Mar 2016 17:21:29 +0100
> 
> +While the using the @command{return} bounds can propagate through
> +execution causing a boundary violation.

This sentence needs to be rephrased.

> +@kindex set mpx-bnd-init-on-return
> +When set to true bound registers will be set to the INIT state when
> +using the "return" command.
> +@kindex show mpx-bnd-init-on-return
> +Show the state of mpx-bnd-init-on-return.

This last sentence should explain what is shown; just referring to the
variable name doesn't do the job.

> +  add_setshow_boolean_cmd ("mpx-bnd-init-on-return", no_class,
> +			   &mpx_bnd_init_on_return, _("\
> + Set the bnd registers to INIT state when returning from a call."), _("\
> + Show the state of the mpx-bnd-init-on-return."),

For the 'show" part, we usually use the following wording:

  Show whether to set the bnd registers to INIT state when returning from a call.


Thanks.