From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118847-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31561 invoked by alias); 8 Jan 2015 13:34:35 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 31552 invoked by uid 89); 8 Jan 2015 13:34:35 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout23.012.net.il
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Jan 2015 13:34:34 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NHV00K001J2CI00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Thu, 08 Jan 2015 15:34:31 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHV00KYH1PJ9070@a-mtaout23.012.net.il>; Thu, 08 Jan 2015 15:34:31 +0200 (IST)
Date: Thu, 08 Jan 2015 13:34:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 1/3] Remove superfluous function key_is_command_char()
In-reply-to: <1420689885-31156-1-git-send-email-patrick@parcs.ath.cx>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: gdb-patches@sourceware.org, patrick@parcs.ath.cx
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83zj9t5rbe.fsf@gnu.org>
References: <1420689885-31156-1-git-send-email-patrick@parcs.ath.cx>
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00181.txt.bz2

> From: Patrick Palka <patrick@parcs.ath.cx>
> Cc: Patrick Palka <patrick@parcs.ath.cx>
> Date: Wed,  7 Jan 2015 23:04:43 -0500
> 
> The function key_is_command_char() is simply a predicate that determines
> whether the function tui_dispatch_ctrl_char() will do anything useful.
> Since tui_dispatch_ctrl_char() performs the same checks as
> key_is_command_char() it is unnecessary to keep key_is_command_char()
> around.  This patch removes this useless function and instead
> unconditionally calls tui_dispatch_ctrl_char() inside its only caller,
> tui_getc().

But tui_dispatch_ctrl_char punts when the current window is the
command window, doesn't it?  This means we are losing the possibility
to handle command keys in the command window.

Thanks.