From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, yao@codesourcery.com
Subject: Re: [RFA] configure gdb/gnulib with --disable-largefile if largefile support disabled.
Date: Thu, 04 Dec 2014 06:47:00 -0000 [thread overview]
Message-ID: <83zjb352te.fsf@gnu.org> (raw)
In-Reply-To: <20141204031828.GD7899@adacore.com>
> Date: Thu, 4 Dec 2014 07:18:28 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org, yao@codesourcery.com
>
> > > But gnulib ignores this fact, and so tries to determine how to
> > > enable large-file support irrespective of whether we want it or not.
> > > This patch fixes the issue by passing --disable-largefile to gnulib's
> > > configure when large-file support in GDB is disabled. This is done
> > > by first enhancing ACX_CONFIGURE_DIR to allow us to pass extra
> > > arguments to be passed to the configure command, and then by modifying
> > > GDB's configure to pass --disable-largefile if large-file support
> > > is disabled.
> >
> > Shouldn't this be reported to gnulib folks and preferably fixed there?
>
> I do not think so, because gnulib can be used independently of procfs,
> in which case you would probably want gnulib to have large-file support
> by default. It's only in GDB and binutils' peculiar situation that
> we need to disable by default.
Gnulib could have the necessary magic to DTRT in both situations, I
think.
Anyway, I don't think it's wise to not even tell Gnulib folks about
this. If they say it's just our problem, so be it. But they might
have other proposals.
next prev parent reply other threads:[~2014-12-04 6:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 5:46 [PATCH 0/7 V2] Import the rename gnulib module Yao Qi
2014-11-26 5:46 ` [PATCH 2/7] Use readlink unconditionally Yao Qi
2014-11-26 5:46 ` [PATCH 1/7] Import readlink Yao Qi
2014-12-03 10:48 ` Joel Brobecker
2014-12-03 12:08 ` [RFA] configure gdb/gnulib with --disable-largefile if largefile support disabled Joel Brobecker
2014-12-03 17:59 ` Eli Zaretskii
2014-12-04 3:18 ` Joel Brobecker
2014-12-04 6:47 ` Eli Zaretskii [this message]
2014-12-13 16:29 ` Joel Brobecker
2014-12-04 2:17 ` Yao Qi
2014-12-13 14:46 ` pushed: " Joel Brobecker
2014-11-26 5:47 ` [PATCH 6/7] Use canonicalize_file_name unconditionally Yao Qi
2014-11-27 7:36 ` Joel Brobecker
2014-11-28 3:07 ` Yao Qi
2014-11-28 3:43 ` Joel Brobecker
2014-11-28 10:43 ` Yao Qi
2014-11-28 14:46 ` Joel Brobecker
2014-11-26 5:47 ` [PATCH 7/7] Import rename module Yao Qi
2014-11-26 5:47 ` [PATCH 4/7] Use lstat unconditionally Yao Qi
2014-11-26 5:47 ` [PATCH 5/7] Import canonicalize-lgpl Yao Qi
2014-11-26 5:47 ` [PATCH 3/7] Import lstat Yao Qi
2014-12-02 17:01 ` Joel Brobecker
2014-12-03 9:48 ` [pushed] callback.h:struct host_callback_struct compilation error on Windows hosts Joel Brobecker
2014-12-04 1:09 ` Yao Qi
2014-12-04 5:42 ` Joel Brobecker
2014-11-26 15:40 ` [PATCH 0/7 V2] Import the rename gnulib module Eli Zaretskii
2014-11-27 3:48 ` Yao Qi
2014-11-27 7:41 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zjb352te.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).