From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77531 invoked by alias); 21 Dec 2017 03:29:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77513 invoked by uid 89); 21 Dec 2017 03:29:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Explain X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Dec 2017 03:29:40 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vBL3TXXq003737 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 20 Dec 2017 22:29:38 -0500 Received: by simark.ca (Postfix, from userid 112) id 908EA1E59F; Wed, 20 Dec 2017 22:29:33 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id E90A31E4C4; Wed, 20 Dec 2017 22:29:31 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 21 Dec 2017 03:29:00 -0000 From: Simon Marchi To: Stafford Horne Cc: GDB patches , Openrisc Subject: Re: [PATCH v3 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p In-Reply-To: <20171219142257.13402-5-shorne@gmail.com> References: <20171219142257.13402-1-shorne@gmail.com> <20171219142257.13402-5-shorne@gmail.com> Message-ID: <842bc3de1ad8cd8a568127aedeb58275@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 21 Dec 2017 03:29:33 +0000 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00464.txt.bz2 On 2017-12-19 09:22, Stafford Horne wrote: > tdesc_register_in_reggroup_p in now able to handle arbitrary > groups. This is useful when groups are created while the > target descriptor file is received from the remote. > > This can be the case of a soft core target processor where > registers/groups can change. > > gdb/ChangeLog: > > 2017-06-06 Franck Jullien > Stafford Horne > > * target-descriptions.c (tdesc_register_in_reggroup_p): Support > arbitrary strings. > * NEWS (Changes since GDB 8.0): Announce that GDB supports > arbitrary reggroups. > > gdb/testsuite/ChangeLog: > > 2017-06-06 Stafford Horne > > * gdb.xml/extra-regs.xml: Add example foo reggroup. > * gdb.xml/tdesc-regs.exp: Add test to check for foo reggroup. > > gdb/doc/ChangeLog: > > 2017-06-06 Stafford Horne > > * gdb.texinfo (Target Description Format): Explain that arbitrary > strings are now allowed for register groups. > --- > gdb/NEWS | 7 ++++ > gdb/doc/gdb.texinfo | 9 +++-- > gdb/target-descriptions.c | 74 > ++++++++++++++++++------------------ > gdb/testsuite/gdb.xml/extra-regs.xml | 1 + > gdb/testsuite/gdb.xml/tdesc-regs.exp | 3 ++ > 5 files changed, 53 insertions(+), 41 deletions(-) > > diff --git a/gdb/NEWS b/gdb/NEWS > index 44f481d1f5..7d27262aee 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,13 @@ > > *** Changes since GDB 8.0 > > +* GDB now supports dynamically creating arbitrary register groups > specified > + in XML target descriptions. This allows for finer grain grouping of > + registers on systems with a large amount of registers. > + > +* On Unix systems, GDBserver now does globbing expansion and variable > + substitution in inferior command line arguments. > + > * The 'ptype' command now accepts a '/o' flag, which prints the > offsets and sizes of fields in a struct, like the pahole(1) tool. > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index e169260e7e..a71faaa89c 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -41761,10 +41761,11 @@ architecture's normal floating point format) > of the correct size for > @var{bitsize}. The default is @code{int}. > > @item group > -The register group to which this register belongs. It must > -be either @code{general}, @code{float}, or @code{vector}. If no > -@var{group} is specified, @value{GDBN} will not display the register > -in @code{info registers}. > +The register group to which this register belongs. It can be one of > the > +standard register groups @code{general}, @code{float}, @code{vector} > or an > +arbitrary string. The string should be limited to alphanumeric > characters > +and internal hyphens. If no @var{group} is specified, @value{GDBN} > will > +not display the register in @code{info registers}. > > @end table > > diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c > index 88ac55f404..1435f3f4cf 100644 > --- a/gdb/target-descriptions.c > +++ b/gdb/target-descriptions.c > @@ -111,12 +111,11 @@ struct tdesc_reg : tdesc_element > int save_restore; > > /* The name of the register group containing this register, or empty > - if the group should be automatically determined from the > - register's type. If this is "general", "float", or "vector", the > - corresponding "info" command should display this register's > - value. It can be an arbitrary string, but should be limited to > - alphanumeric characters and internal hyphens. Currently other > - strings are ignored (treated as empty). */ > + if the group should be automatically determined from the > register's > + type. This is traditionally "general", "float", "vector" but can > + also be an arbitrary string. If defined the corresponding "info" > + command should display this register's value. The string should > be > + limited to alphanumeric characters and internal hyphens. */ > std::string group; > > /* The size of the register, in bits. */ > @@ -1279,17 +1278,13 @@ tdesc_remote_register_number (struct gdbarch > *gdbarch, int regno) > } > > /* Check whether REGNUM is a member of REGGROUP. Registers from the > - target description may be classified as general, float, or vector. > - Unlike a gdbarch register_reggroup_p method, this function will > - return -1 if it does not know; the caller should handle registers > - with no specified group. > - > - Arbitrary strings (other than "general", "float", and "vector") > - from the description are not used; they cause the register to be > - displayed in "info all-registers" but excluded from "info > - registers" et al. The names of containing features are also not > - used. This might be extended to display registers in some more > - useful groupings. > + target description may be classified as general, float, vector or > other > + register groups registered with reggroup_add(). Unlike a gdbarch > + register_reggroup_p method, this function will return -1 if it does > not > + know; the caller should handle registers with no specified group. > + > + The names of containing features are not used. This might be > extended > + to display registers in some more useful groupings. > > The save-restore flag is also implemented here. */ > > @@ -1299,26 +1294,9 @@ tdesc_register_in_reggroup_p (struct gdbarch > *gdbarch, int regno, > { > struct tdesc_reg *reg = tdesc_find_register (gdbarch, regno); > > - if (reg != NULL && !reg->group.empty ()) > - { > - int general_p = 0, float_p = 0, vector_p = 0; > - > - if (reg->group == "general") > - general_p = 1; > - else if (reg->group == "float") > - float_p = 1; > - else if (reg->group == "vector") > - vector_p = 1; > - > - if (reggroup == float_reggroup) > - return float_p; > - > - if (reggroup == vector_reggroup) > - return vector_p; > - > - if (reggroup == general_reggroup) > - return general_p; > - } > + if (reg != NULL && !reg->group.empty () > + && (strcmp (reg->group.c_str (), reggroup_name (reggroup)) == > 0)) I suggest reg->group == reggroup_name (reggroup) > + return 1; > > if (reg != NULL > && (reggroup == save_reggroup || reggroup == restore_reggroup)) > @@ -1421,6 +1399,28 @@ tdesc_use_registers (struct gdbarch *gdbarch, > void **slot = htab_find_slot (reg_hash, reg.get (), INSERT); > > *slot = reg.get (); > + /* Add reggroup if its new. */ > + if (!reg->group.empty ()) > + { > + struct reggroup *group; > + bool group_exists = false; > + > + for (group = reggroup_next (gdbarch, NULL); > + group != NULL; > + group = reggroup_next (gdbarch, group)) > + { > + if (strcmp (reg->group.c_str (), reggroup_name (group)) == 0) Here too. > + { > + group_exists = true; > + break; > + } > + } > + > + if (!group_exists) > + reggroup_add (gdbarch, reggroup_gdbarch_new (gdbarch, > + reg->group.c_str (), > + USER_REGGROUP)); > + } Could you factor this out in a separate function? It would probably be useful to have a general-purpose function reggroup *reggroup_find (struct gdbarch *gdbarch, const char *name); Which you could then use here if (reggroup_find (...) == NULL) { // Create group } Thanks, Simon