From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2084.outbound.protection.outlook.com [40.107.115.84]) by sourceware.org (Postfix) with ESMTPS id E78EC385829F for ; Thu, 30 Nov 2023 20:09:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E78EC385829F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E78EC385829F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.84 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701374989; cv=pass; b=DoTQVwqmpPmCWcdHNb2Wr/NymdKA8E6jQj2LZxnh5iPnY3EICjg6FzuLT8iGd7ZhlyIYgR7k82VghHuueQ7se8ZT4HnDU9D75fB2pjZ+BCI6Fqqgs8oZK2SlRH1SoO0f00XiVPuS5iFFsP0e4C4Hcptc5luk/dz+2kB3OHLjxmY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701374989; c=relaxed/simple; bh=g63jbJE/hXZssB3JrxSJx0OOu6uPiSMWv9wqbijP1Uw=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=G8kbrPkYl/oFKBYICpm21LWLj3q+Ip86olZnzbknTNBCTchuUBJAPXuWOQxEcv4NN42zza+rNVJHs7/2ZSR7QKqXGUJE0yt7iFu26tUIc/uceiKLMy5RXU2TZRe9SFB1RaxOFvU/h6hDtmYPIlJqmXL+xRXOBSM/ASfrAyKVvSQ= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QzCgu1tA3eOa0Uqj4bSrnNYLsQpY6PIpqSTv3023radBEhTh4deSF7h803fSG8SEW5kCFMeehpTjh+BMRg67YxnGJ/CgvLmR/5Rn4CEPJzvuz0uptzYsT6zqqXHXe9jE7sAhngLMirDym472+zublgVIp1+z779/hCFwyX/3rBPxKID13uIl9jG7iNz2IXgkhcF5ASIdgxVjNfJU96R2biEaSwhxae0ZB8Pv1hpdmbbiXHZIanucowHc78rLhAJGgLCYZAO49SDXQvG4V54+S5slMn+LQLxUVGznV/6hljeYb/jOyrAUuhEB7491JXPArfc9v2JfHhj8Injfm8Lufg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ptjp09lKrRyRK2jhsEYaha5bLU69NWjcdTYIVAqLRyw=; b=CFpkNVZu+S23ek0OL/ffJ82ze8QH9O/NAYsQQ4tanWK+3MCW0UwHO8KW7mfutgDqgxjLF5XA3/su/XyPhgabx+fwWlFceuezA5JDTTuvcJvyuzoSjpZFS/gucs4cObUjJ0b96TWFxvRkADG9HyZNbCeolGudCpHc1xb1oN1QOSC/XreHYGPwf8uERGvsy6lmTBszOooJ/eJVBv2naCHsbrc5Tg7tWOOSx7j9HAWkCZvjvgtlsosEIqTHcPxr04X6IwXeFINWS/wirR19bPKIMqN+RT9E4UGzYEw5jCXqATcc8k9UzlQzl3WIiyFhdLUmPRJP0PmU/RbIg91oFJ5OeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ptjp09lKrRyRK2jhsEYaha5bLU69NWjcdTYIVAqLRyw=; b=tlyIQn0I9FWDebUR9vDz34tlj9TdDIH2h8tn6bExB/HLav5Z2y/Rllywj5veFEo5UZhew8jwvxFlLSqpZ9Z03WcYcCl+DmxI5GkvX2/uvt8TzwUaTjuPtr0e2KrB5SQHc/ouY62GBi++ODcZux+ItcMoVn9K9VMq5FkhS3T8/X84/iFhjb2/GH5N9Sx4i5F7QCKPsj1N6Bs0r93pWvfVta+s2eF62MZ1BrOmfBK/GSjlrBbQ4mtwvyebY+q5qdkDP7DTGj738n/Qi/HDb686CQyoEOmGz8e8/64gV39TOp3/xhdtcduBwpH4qeAWc1lT+XZxA5NcBiR71Ii76a4TBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YQBPR0101MB6284.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:31::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.24; Thu, 30 Nov 2023 20:09:45 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::9378:63a0:1c28:2df7]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::9378:63a0:1c28:2df7%3]) with mapi id 15.20.7046.023; Thu, 30 Nov 2023 20:09:45 +0000 Message-ID: <84a59ee9-41d1-4641-95c4-87f4850b345f@efficios.com> Date: Thu, 30 Nov 2023 15:09:42 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/24] gdb: change regcache interface to use array_view Content-Language: fr To: "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" Cc: Luis Machado , John Baldwin , Andrew Burgess References: <20231124212656.96801-1-simon.marchi@efficios.com> <20231124212656.96801-6-simon.marchi@efficios.com> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQXP288CA0007.CANP288.PROD.OUTLOOK.COM (2603:10b6:c00:41::22) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YQBPR0101MB6284:EE_ X-MS-Office365-Filtering-Correlation-Id: e1ec5345-9ddd-43e0-f53f-08dbf1e04bce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YV+M2QU1JimjOlnt9J+hASkXFaxJHNzsk1eWuVluOZ1p6cKRDmTBbwRR2Y1K6jeZ/n04sQZatOqQ7JJmUHTSYxBKzBIAioU8JtTnnJtylA41XH4oJdFm7LSdVSX67dxYwnG4u9vlEyvL/Bmf5qvmvQwlqjymeC5eM9L25h5ZVLreAa16wRYFahpkjIvkQylTRuCYdkBa5CYQlS267cN76qW0RaGEUKm1jcwAqoXYGw5q+QPhtmJCF5ZW77OonaxH/7MMAuEqcA3MHN2rZRoZjH42tyMv0M9LlhBymHTHAvsvkhCvNIFTnix2ofBpaQHKIsIGYfhAcF6Tm2DIzz0DxO2xvjUHYmw6v2zHO+MCfDcXwUoxJl8jsaeV+7UDY590twjiEa0uLQpsQZSdSjr6MsnN1lHsuC52FJ++dddLbz9xnb9SUbFo6wzBCwT7xSAq86pqnHjoA94RCVSw2rtNipAFZsY0V+U0rA3a2bPazMA9OfaRB3CAn5v9YPLHWLM80EeaVogOfaPjivzcCodwb0PwoZzZ8poQOrcv1v4m3W/SBXV5HdgM3LEPp6cZrRkIcEa7nFIYit8yg0GMVoOH/gFeVvmRJ3EIe4q/9utxjS+ck5WD8PrN9sblIC5xPoVRH1edUx0irL17AnQyYOR6Ow== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39830400003)(366004)(376002)(396003)(136003)(346002)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(31686004)(83380400001)(26005)(38100700002)(41300700001)(36756003)(53546011)(6512007)(2616005)(6666004)(4744005)(6486002)(2906002)(5660300002)(31696002)(54906003)(44832011)(316002)(66476007)(110136005)(66946007)(66556008)(6506007)(478600001)(8936002)(8676002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzZib2xoNlFIc20rMzVFajF5MVJqOGpncHo4UmkvcldLQnNzM2dQT2xjTzJu?= =?utf-8?B?cDNKSGM5QzBBYTNRNVk5aEZISTBPeUZmZ21LbmNLaUlLekQ4M3lzaGpWQmts?= =?utf-8?B?SytzL3pRMWdVMk1OSys3RHJVTjVZYXRpdlVaUFlaZmFhUjZ1VUYwRE9YM3Rn?= =?utf-8?B?SXoyekVpTXVPeXdIeUNtTGM1c3QwWlpkWURmOHA2N08vSGdqd1N2Q3RXdVhF?= =?utf-8?B?ZHR5Q1RKTW5WWFBRRXpqK3BTMURSY25iRUZTMVJBaUJqY2lPem9LSU9qUXRW?= =?utf-8?B?VDdCQmRXNWlPT3Z6dFRWTGxQKytOQ203MVhEOXNjSktjZDBFSXovNU1kUnRG?= =?utf-8?B?RVZGNXpyS3l1MFpZeUgrNkJnRTVzN3RKLzJGVC9xcDZsMzczQ2JFQUk4MDR6?= =?utf-8?B?YUoxUGxpUlRDVkZKRzdVS1oxMHBLM3lZYW5kZDh3cTBkWjF1WVdnSHpiaWpT?= =?utf-8?B?azE5V2R2djNCZUNVY29Ha3Qyb216SWwwcFJCTjlSajE2SXJmMk1aU09hRi9V?= =?utf-8?B?R2pwUFVuRThpWExNamZwcThLK0xVbGJqcjdxQlZHNFFEVVF6bFFhczdFRzZ5?= =?utf-8?B?Y0NPZUc2WlJWcWtSOGEzOUpZRDduWWM0N0F5ZHZQZU1PZzRORUh4c0IyVFVH?= =?utf-8?B?bjY3MUN6Mml0cTc3NU95Wk14L1BsOXFmbDJ3WG9veFhVVWZRZEhianZKRGFP?= =?utf-8?B?TWFIZG1ZV3lQaFBFM212T3VobGJ0clBBT0JpMGxNaUtHamc0NjZLelpmWDBk?= =?utf-8?B?aHh1TTlJa1VNbU8xTmZYR0dOUnM0Y3J5SG5GK0lrd05Nck9vSFd6UWZ0S1pm?= =?utf-8?B?RHpWNFh5WkhIQTFTMzdnOEc5SXhxRnJPL2FnUEpRTmc4RG1aUy9FMHV2UzhP?= =?utf-8?B?OFZpK0RHZ1JDOVZhSkV5ZE1LVkNaQlR1NDdVVkk2T3ZMNlhhK3hQVUlPem5B?= =?utf-8?B?THd6WEFTMWwvWEhjTVhmL3FIc1VJUEdCQmdYdFNDR3A4YTZ3VVZmbDl2TWhJ?= =?utf-8?B?eXE2L21IUXhQQWg4NE1CczVvN1kxbVdIa1ZlNmtNMTI0ZGxXV05QWndnVXhz?= =?utf-8?B?aFA1N2oxR1ZPMmxkT2tyUWhERkVFaUUzZDd5ZHRsWWFLOG9yd0FXNDRHK005?= =?utf-8?B?N3d6K3hxOTBqczdKcEgwUEZwaGVJWjh0VkQyN0JkczJCKzU5ZThxQUVJY2ZM?= =?utf-8?B?SVJpcHR6TVdjZGU2bkhCNnVhcEp3VU5BL3c3bmpQbFBXM2FmYUh6RTdGZHNW?= =?utf-8?B?VGY0NFFzQkZUSjVadDBaejUwc1FYNDJENm9IK0VIamkwa0dCMjl4c0YwT3NN?= =?utf-8?B?WFFWYy9qVUtWMndEalRCREV1OFRyUWZyT1dLUkpxMExUVGpsZVk3TDQxb0lj?= =?utf-8?B?a1FBdXVQT0NYaFFMOCtQNXk5YkFmenYzNGpmZllraFZhdHNxSXF1QzZsTU9E?= =?utf-8?B?QkU4ZlpjbjlkYTNlUzFhRlYrdGxwemFQSGZBWWdqNmUycDlabkRldTNUSDhL?= =?utf-8?B?S3lMMXJpcjhvNGpOSGtnaTd5N0ZIeWpmSlByZkJ0NEF1YTU1OEVEZ1hUeHdG?= =?utf-8?B?aTlwRUJlT2dMZ3BTTzIwdWlrNkQ1WHJDY0QvV1ZqdWpwUHdHMVl0VlZySGR2?= =?utf-8?B?RFkvZThGUzYxZkNLaTNSV1JLVVZNd2kxb1JCV3p3VkdiZWw4MjVEQnVlMmJT?= =?utf-8?B?cWtYS0dhY3NIWjc2Zy9yaS8rWlhCSkZscFFTZnR1bkNEWXd6Q3ZXUVNGUU9R?= =?utf-8?B?eGhGdlJWMWFVYU52eVhXTFhRSm1Jb3JxcDZFa2ZmSmUvOUsybzE4djVOYlFI?= =?utf-8?B?WlVoTW1ZdG1rUmhDQnlKVE93SVRNc1FJZnZnUEQwY2FzVVQyS1NSbHhoRVYw?= =?utf-8?B?bW5XeVdnS2M4MTJpbFRMbjg1R3NCS0x5UEtlTjc0SUdvQWZ6QjRmREdhT0cr?= =?utf-8?B?blg2VHBTUE9mUVJzb0VjaWdCYTdkVWl0VERITDZ2ZnhEMGpXNXVKRi9sVkNC?= =?utf-8?B?dkRwMDdUMWUzOTZEY2V1akZWZjFiU2xTeW9yeEIveGdOU1dJWXhZZHF2QUkw?= =?utf-8?B?VTBYZm1RRlhaOUF0SkpzM2NLN0Y3NnFYbFZ1bVJmd1FIanpaK0FXUDNjSThI?= =?utf-8?Q?AhhtueAAjhDsQHwiAwXVrLNk+?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1ec5345-9ddd-43e0-f53f-08dbf1e04bce X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 20:09:45.3310 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BQXgLVTZ36g9S9haPavkHyjY65zRBhMQAEO9InLW85/L3qtcyeS8z75wNXGs5UVgEQ8gIZEB6mmR+fIoJ2EDtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB6284 X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/30/23 12:58, Aktemur, Tankut Baris wrote: >> @@ -650,13 +677,13 @@ template >> void >> regcache::raw_write (int regnum, T val) >> { >> - gdb_byte *buf; >> - >> assert_regnum (regnum); >> - buf = (gdb_byte *) alloca (m_descr->sizeof_register[regnum]); >> - store_integer (buf, m_descr->sizeof_register[regnum], >> - gdbarch_byte_order (m_descr->gdbarch), val); >> - raw_write (regnum, buf); >> + >> + int len = m_descr->sizeof_register[regnum]; >> + gdb_byte *buf = (gdb_byte *) alloca (m_descr->sizeof_register[regnum]); > > We could use `len` as the argument to `alloca`. Could you also consider naming > the variable `size` instead of `len`? It seems to be used more often than `len` > in this patch, and also fits better to array_view's `size` method. Agreed, fixed locally, thanks. Simon