Re: [PATCH 2/2] AArch64: add support for DFP (Decimal Floating point)

[Luis Machado <luis.machado@arm.com>]

On 5/24/22 08:55, Christophe Lyon wrote:
> 
> 
> On 5/20/22 11:06, Christophe Lyon wrote:
>> This small patch adds support for TYPE_CODE_DECFLOAT in
>> aapcs_is_vfp_call_or_return_candidate_1 and pass_in_v_vfp_candidate,
>> so that GDB for AArch64 knows how to pass DFP parameters and how to
>> read DFP results when calling a function.
>>
>> Tested on aarch64-linux-gnu, with a GCC with DFP support in the PATH,
>> all of GDB's DFP tests pass.
> 
> More precisely, patch 1/2 has a side-effect of enabling the GDB DFP tests, some of which fail without this patch 2/2:
> gdb.base/dfp-test.exp: Call function with many _Decimal128 arguments.
> gdb.base/dfp-test.exp: Call function with many _Decimal32 arguments.
> gdb.base/dfp-test.exp: Call function with many _Decimal64 arguments.
> gdb.base/dfp-test.exp: Call function with many mixed decimal float arguments.
> gdb.base/dfp-test.exp: Call function with mixed decimal float arguments TEST.
> gdb.base/dfp-test.exp: Call function with mixed decimal float arguments.
> gdb.base/dfp-test.exp: backtrace function with correct _Decimal128 arguments.
> gdb.base/dfp-test.exp: backtrace function with correct _Decimal32 arguments.
> gdb.base/dfp-test.exp: backtrace function with correct _Decimal64 arguments.
> 
> OK?

This is OK. Thanks!