From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150052.outbound.protection.outlook.com [40.107.15.52]) by sourceware.org (Postfix) with ESMTPS id 8265A3839C5F for ; Mon, 16 May 2022 14:47:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8265A3839C5F ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=oWoi30703vIZvxyeBJ2CVH05ASp+OwwJcuAOdmYa1kSNCZobynt9Q8IbrlDwwk9L3sxJFoyLgPHO44H0QHDX6ZDCgMNshpGYzC/5Tyxn7TY4a8nxENmklq1KAF7sGSuNyAxggD37cc0XFd3aQlGyLhelJHxhBklg9exH2SeWCw5sUIL4p/ya4aH9bnAVzI3ctsbkCsKounLtE+1dYyamI7FM9SqXK39bwPYZeotRng/G3xsJe8dpoqBNGr7gqR7zfGCW7oVcKljvNPzMUYnyP73tq5yLrw1WgaJ/BxuAy92rK/uNBl1nEZYkqw6w+Xdk1VMtt91h1Pb120lG9DXXNA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g9IGz5wnQpEVngLyKRJ0CwGMh6bh9cT3GCth1+GtTVk=; b=RZnRcjdQxCUwmRmJKSREyvb9LSC2lww+5ZKQUOItEFoTpnDL7riQyng9cgydrCoJKqsEqNAdwgYF3hPMzVrOdhimzmiR4wA2d+rc3nE5il7+g8haEokt7WN2IlB4f9LsIwsK0fxzLO2UDfXCQeIwSfzi9Ho45IIETvb33Axum/nDaXXoZyELM+WqZr5uzBP4vYUoOl7ryB0aM0q1IqXisPOFDq1aP00umilGxX6DwpzLztD2/iUtfN1Z/fw97F4sJ2pYaNW03oJKLxol5KiJQ6USzZIcVK33QD6WuLso6CTLRE0UD+9fdPA638NViDGEqI5qMSIsbVJhxdYi7WtR4g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR06CA0254.eurprd06.prod.outlook.com (2603:10a6:20b:45f::29) by AM0PR08MB3844.eurprd08.prod.outlook.com (2603:10a6:208:101::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.17; Mon, 16 May 2022 14:47:05 +0000 Received: from VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::15) by AS9PR06CA0254.outlook.office365.com (2603:10a6:20b:45f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14 via Frontend Transport; Mon, 16 May 2022 14:47:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT029.mail.protection.outlook.com (10.152.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Mon, 16 May 2022 14:47:03 +0000 Received: ("Tessian outbound 42cead292588:v119"); Mon, 16 May 2022 14:47:03 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 361df29cf6e5ea29 X-CR-MTA-TID: 64aa7808 Received: from dfcfaa9eb18d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A0FE158A-990F-4A72-8CDD-1EA2A47B1E7A.1; Mon, 16 May 2022 14:46:56 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dfcfaa9eb18d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 16 May 2022 14:46:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gUOxd1UwRK4PlIessUWEvl5K4eEfpYm2Xd2hV/0zHmcn0ohjKj82ilWwYKSVGXNAl1y41PuYkkXuH2T01q5WWcpcPU447O9aZ/skHhfGkfpWwoaWR7LUfIeTLC5iEXHY15n3PAhKBJKlUGLfeYExuoWV4/mHzXp9Gqavud2eGhvnxfRxBprQvDQMXoAy59ZH7PCRFRR+IiYFc9b8UV+JFzLlALkYgu63M/qPmkTPExF8KVR7N3gKTgjLrz9U+xCbCaEdAgZmz+YN3bLqRISlS0Wn9LmEa495pYs7hgdG44G182/h/hypck0wa7iK+wxw8d+8X2le1jdNcxpJhY9eqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g9IGz5wnQpEVngLyKRJ0CwGMh6bh9cT3GCth1+GtTVk=; b=O7gK5VUF+aZO2gX6luD/CtMJxHRhxwDg/riTf19dgBDb3CGoGQAw/IDt6plDIINp9qiNGiezulAjfzVq5JkUxb/JzgazhhiyUQi9eEwNQZR3unuMrjuTUF8+ApqY3i1SYjtfphs49vJf9yVrAl6xwFJZGrHw3mm6SgZq3LZZMMCrljEKdcmk5pnZCFseSK2Xn9qPL2h8969xsrdOkU7FMf5IPYrh5h9OdR+2xUVeDGHGHVqfdaMf7dQyedoi07R6W+6E9soeyhEOw0gF7yR5gNCL65ib63PfN5l42kDyEsSfa5VH0t0z678a8E0SUbZH9Yh9BUpf4HZnxUPR9Z4rSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) by AM6PR08MB4868.eurprd08.prod.outlook.com (2603:10a6:20b:c5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Mon, 16 May 2022 14:46:54 +0000 Received: from VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::1916:206:dd8b:6a91]) by VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::1916:206:dd8b:6a91%4]) with mapi id 15.20.5250.018; Mon, 16 May 2022 14:46:54 +0000 Message-ID: <8596b573-ad8e-df22-592d-b342c89a315e@arm.com> Date: Mon, 16 May 2022 16:46:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/3] gdb/arm: Set the correct address to the FPU register on Content-Language: en-US To: Yvan Roux , gdb-patches@sourceware.org Cc: Torbjorn Svensson References: <20220516135454.GA27993@gnbcxd0114.gnb.st.com> <20220516135803.GB27993@gnbcxd0114.gnb.st.com> From: Christophe Lyon In-Reply-To: <20220516135803.GB27993@gnbcxd0114.gnb.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA9PR13CA0151.namprd13.prod.outlook.com (2603:10b6:806:28::6) To VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 534cb91c-35d7-488a-1069-08da374af13e X-MS-TrafficTypeDiagnostic: AM6PR08MB4868:EE_|VE1EUR03FT029:EE_|AM0PR08MB3844:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hF/RcIZwjjBp4yg4FWSFVe0pQIIYvmY6SlZCpS65G4Tcpzs9DhHSI1Pa4PFFe4QhSMp9vjZ01BD4bsCDtMmEdilxyVviuxlUc4O31iAgS48eEt67biOkhOFlSe0VWHaF2DqTcisG+OhVlqCdI+OOB4LHnthOiRTDfU8cTCdvTexU5UJHp0bq8YCSAptfzqpTsa6sXPGp8fmIJg6fikB7cK6xGXl3B/JjZP94qacEvZBQx9Oh/cI+EGQXYQVrGlT2k9zwAUNsGwrBNmueJFui3fk4QR/CB31YHQvIjJvEkl3X7za/1ZEX04SzUxpO4AEEr8go/owC0iT7t/+svEuZbAUzVnjyEeSbDlFMy/YbWuOLo84DHZIuK/C3JN+8G45xiP9OulqtowMlv3EniADw3ZHdllKRkBphlju+Xn3TZPoIzpNqEfQb4XEWMO3R93PFCGMrEhS1cWs9pf8weCVi0PSZTsrZ6iVJXZ7C1TvXb1HYyrj01GlMrj1RgQogt2LpAdscmuxhkmilb/JcL/2Vy5WNGe8mR6uU/OuXElWJ6v1wQB1yOGH4LGucrcMXAHpTl/D+dgqFo0nAH/lTtpoJFRpk1pcfKcbAMnBfG6lTIWy3ggGjxh/mTBJGwc5iZRvRtFlchOe/QC9i7uwH4woMOB4V9NH3xkPiQ9+TbaTVQpBHUo2zAWu+4OAvsaNCMVIiu5DEInapN1Oo6hKPPvv0ja7xlGjfpXIrTdllXAHhEV4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3694.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(44832011)(86362001)(2616005)(31696002)(6486002)(2906002)(6512007)(83380400001)(186003)(6506007)(38100700002)(508600001)(66476007)(26005)(36756003)(66556008)(66946007)(4326008)(8676002)(6666004)(316002)(53546011)(31686004)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4868 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: efd99e64-16a6-4151-5aec-08da374aeb31 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hFp2D4jGILktAa45NGxyW/OfWVdr+v9t2kYMDEunpx3bPpAyDc6Nzjc+7xIpUt2mtHH6AFQK8Wal6WyjqIzscYwavTD4W05gAnsroPUBSov1zhI2lRnbkMfjZPPJLVTxWQIE7hBmult0G+mnpKDWRHTE+TVdSnIfEkKhk0nASUn3ZpRC1aXIryeHUhJM5mTV1M/gnf3I0CNoQCxQKx+5envqWKxF9+wob4VWosJrJn/Gn9vRkBC2esYtjbi+sBQv2bk3Bph7GHFOzV8oB5c1cjFQD+tHI5X1ko03HyOLyCPIEAZ1iRT4d6BgLZgLmGmhigLbMHX29d8CiUOjSrx8ZTXJ8f6rMvPT2bVAOBn8QYeJp7Bt0PTV4aEs5+xqczxH86LzoBLy0kq3+VClFVSBCCLPXMlYe1wxq/ABZbMSidQxF/fjZ7fiyzvgD9zMtlr1gyhBcxPTMTohhD3T1lP4JMnkvUgpyw2p/8EXeIFBuKzyx6Is4Al7i3F5x7BTJZgxD/BcjjF4aweFHDcGirER/s/28Ak5bgQM6OgcdFY4UbIbhwRdiJ/KfiFWYHNtTBHN7Y6WKUy6sq/SkS1xLJ44cQ+gyuMGXkFXlI8gM2EycntcElTxGROJy+UIXUPwehBBl7sfvIBdneialrQwozOpkOK00hMo6mB8mFkEuObSer7zjKCl/DKJknUmnzdE2halZOarCU5UWF9w3auys2Sxkg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(336012)(47076005)(31696002)(186003)(508600001)(86362001)(316002)(83380400001)(5660300002)(44832011)(6486002)(26005)(8936002)(6506007)(70586007)(70206006)(53546011)(36756003)(8676002)(356005)(2616005)(31686004)(4326008)(2906002)(6666004)(6512007)(36860700001)(82310400005)(40460700003)(81166007)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 14:47:03.9736 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 534cb91c-35d7-488a-1069-08da374af13e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3844 X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 14:47:09 -0000 Hi! On 5/16/22 15:58, Yvan Roux via Gdb-patches wrote: > Registers offsets weren't computed from SP address. > > Signed-off-by: Torbj�rn SVENSSON > Signed-off-by: Yvan Roux > --- > gdb/arm-tdep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 49664093f00..c37254c2ce1 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -3475,7 +3475,7 @@ arm_m_exception_cache (struct frame_info *this_frame) > if (tdep->have_sec_ext && !default_callee_register_stacking) > { > /* Handle floating-point callee saved registers. */ > - fpu_regs_stack_offset = 0x90; > + fpu_regs_stack_offset = unwound_sp + 0x90; Sorry, it looks like this was my mistake when I committed ef273377587d. I haven't checked the manual, and I may have forgotten, but shouldn't this be fpu_regs_stack_offset = unwound_sp + sp_r0_offset + 0x90? How did you test this? Does your patch actually work? Thanks, Christophe > for (i = 16; i < 32; i++) > { > cache->saved_regs[ARM_D0_REGNUM + i].set_addr (fpu_regs_stack_offset);