From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 2/2] gdb: remove TYPE_CODE macro
Date: Thu, 14 May 2020 13:59:49 -0400 [thread overview]
Message-ID: <85cdf905-a7e0-1015-b96f-3170b843d519@simark.ca> (raw)
In-Reply-To: <87tv0j8wph.fsf@tromey.com>
On 2020-05-13 3:24 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> The patch was too big to go through (it said it was waiting for moderation, so maybe
> Simon> it will go through one day). Here it is as an attachment. Here's the commit message and
> Simon> ChangeLog for your convenience:
>
> Simon> Remove TYPE_CODE, changing all the call sites to use type::code
> Simon> directly. This is quite a big diff, but this was mostly done using sed
> Simon> and coccinelle. A few call sites were done by hand.
>
> I agree this is a good direction. I'm not concerned about the contents
> of the patch, I spot-checked it at random and it seemed fine.
>
> thanks,
> Tom
>
Thanks for taking a look, I've pushed the two patches. I'll follow with conversion
of the other properties, one step at a time.
Simon
prev parent reply other threads:[~2020-05-14 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 23:48 [PATCH 1/2] gdb: add type::code / type::set_code Simon Marchi
2020-05-12 20:35 ` Tom Tromey
2020-05-12 20:38 ` Simon Marchi
2020-05-12 21:04 ` Tom Tromey
2020-05-12 21:15 ` Simon Marchi
2020-05-12 21:23 ` [PATCH 2/2] gdb: remove TYPE_CODE macro Simon Marchi
2020-05-13 19:24 ` Tom Tromey
2020-05-14 17:59 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85cdf905-a7e0-1015-b96f-3170b843d519@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).