From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 32E933858C2F for ; Wed, 26 Jul 2023 21:28:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32E933858C2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RB6T25Yf5z3qpC; Wed, 26 Jul 2023 21:28:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RB6T24rPSz4FjK; Wed, 26 Jul 2023 21:28:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690406902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o3GjbmjXFGxTtvrixcv9S8T0qIF7T32uL3zhq9+d5nk=; b=WLK6PHb9fIaXLJjmIJgx5sLThrVCAB2PCrSGYVAI6Gb4edIbmrcKDVscPx9EecqslMfNlP 6d2pHnT7JJlqJ+QE5sV56Hocsk+7vu/y8+cifuDD8qyK/uPtG1L0WiqKa38FY3JudvNd6l YR2iv6jzctGJXcfFN2fOjfe1FDcwg1jxRrHNv9HCoH9FjzKWQJNICblVQ9Zq56oNtuoqrv JFXtP1WPPS1ELSdZACV+kn7/MNZsVdDFszPLXUgh+sCepQTQYRvsgaH5vmkpd45GwuMBf5 zraCE9bpbdfMFyYVd+oy2qR/5QlP1zSGmjYK06SnwoSHc4JYc2znarXXoEkziA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690406902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o3GjbmjXFGxTtvrixcv9S8T0qIF7T32uL3zhq9+d5nk=; b=CW/VyoA1C6UKKFAhJxA3m6Wt8vj+hx/9W8M1jEMsV5iW6ukQImEPKNYujN+oX0wwuyzrhg GCB6BDh1EGqapp7u6HCPWojVecry35pY7BMoI9I2ys/kh83ZZ/Yhja8JGjNIoQ8W2qQMRE l37i0L7O3NcxmbYZ9CVM8ORnXXU6Ncqg9seQDybvXU/FwrSKz81Ldq9qU8FXGDjqsCt7Je U9GB6VTODaQaaSzuhRsw6GQPyON8JMNgwSeh9NJkc+eheEMw5f/hhsdq6tAGJ2U5/7e84x uxvs0mDaJcgZcto0kz3QTMQobl0XQU4kMmZzCv4jUVIEgSW0LYCxybiIiQjZmA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690406902; a=rsa-sha256; cv=none; b=tnpBNuudtC18nPbEcW93VLuNC/tNG16RUMsAQLI2cAr0Hx+8O7GnITXlV+TwMoQcUMmZLT KQqoNNMeKm344iR02ac28SfcC13QPK5pkjtdCfTEmsM2//HPnYCj6GdETzsCsb7Dlfn/o/ Px5w41h51sk58QOi1/eV+4i7yllFiPhITcnebZH4Wmr+Ayan7Aue+P8OQ7++7EInGtNKuJ SAezyZmlIqdWaqXsNmSvlHQYaO5h7vH3ele++mkeB4iHRi17sO03TNTuXe8CVxnPT15mp2 0kLEiyYHIJtkDd+6uj1YxIkjxTmCnJFYpjeu5yoI5CND3ZdwLupyIauabYofzw== Received: from [IPV6:2601:648:8680:16b0:3912:750d:bdfa:28ab] (unknown [IPv6:2601:648:8680:16b0:3912:750d:bdfa:28ab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RB6T222M1zJVH; Wed, 26 Jul 2023 21:28:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <85e81599-890e-4739-a1c3-06b4e7a02528@FreeBSD.org> Date: Wed, 26 Jul 2023 14:28:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 03/15] core: Support fetching x86 XSAVE layout from architectures. Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230714155151.21723-1-jhb@FreeBSD.org> <20230714155151.21723-4-jhb@FreeBSD.org> <46005ee3-1c0e-a35b-e119-ad9ec8109fc3@polymtl.ca> From: John Baldwin In-Reply-To: <46005ee3-1c0e-a35b-e119-ad9ec8109fc3@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/26/23 12:37 PM, Simon Marchi wrote: > On 7/14/23 11:51, John Baldwin wrote: >> Add gdbarch_core_read_x86_xsave_layout to fetch the x86 XSAVE layout >> structure from a core file. >> >> Current OS's do not export the offsets of XSAVE state components in >> core dumps, so provide an i387_set_xsave_layout helper function to set > > Re-reading this after a few months, I wonder if naming this function > i387_guess_xsave_layout would make it a bit clearer. "set" makes it > sound like it's a dumb setter (which it is not). Yeah, that probably is a bit clearer, so I will rename it. > In any case: > > Approved-By: Simon Marchi > > Simon -- John Baldwin