From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>,
Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 6/7] jit: c++-ify gdb_block
Date: Fri, 13 Dec 2019 21:02:00 -0000 [thread overview]
Message-ID: <85f3026a-f05f-c357-d760-0b7c7cd90a02@polymtl.ca> (raw)
In-Reply-To: <c23b8176-923d-bb6d-d3a9-b15b04a84bcc@redhat.com>
On 2019-12-13 3:57 p.m., Pedro Alves wrote:
> On 12/13/19 3:18 PM, Simon Marchi wrote:
>> On 2019-12-13 10:10 a.m., Christian Biesinger via gdb-patches wrote:
>>>> @@ -455,10 +463,7 @@ struct gdb_symtab
>>>> ~gdb_symtab ()
>>>> {
>>>> for (gdb_block *gdb_block_iter : this->blocks)
>>>> - {
>>>> - xfree ((void *) gdb_block_iter->name);
>>>> - xfree (gdb_block_iter);
>>>> - }
>>>> + delete gdb_block_iter;
>>>> }
>>>>
>>>
>>> Have you considered making this a vector of unique_ptrs, so you don't have
>>> to manually delete them?
>>
>> Yes, it's done in the following patch. I went perhaps a bit overboard with the
>> patch splitting, but I prefer to do these changes in many smaller patches, so that
>> if something goes wrong, it's easier to identify the culprit.
>
> I wonder whether it wouldn't be simpler to use std::list<object> for these cases.
I don't think the code would be much different if use used a list, so I don't expect it
to be much simpler. If there's a compelling argument for using a list, I can do the
change, but if it's equivalent, I'd rather stick with what is already done.
Simon
next prev parent reply other threads:[~2019-12-13 21:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 6:03 [PATCH 0/7] Fix and cleanups in jit.c Simon Marchi
2019-12-13 6:03 ` [PATCH 7/7] jit: make gdb_symtab::blocks a vector of unique_ptr Simon Marchi
2019-12-13 6:03 ` [PATCH 5/7] jit: make gdb_object::symtabs " Simon Marchi
2019-12-13 17:54 ` Pedro Alves
2019-12-13 18:45 ` Simon Marchi
2019-12-13 18:51 ` Simon Marchi
2019-12-13 19:42 ` Pedro Alves
2019-12-13 6:03 ` [PATCH 2/7] jit: make gdb_object::symtabs a vector Simon Marchi
2019-12-13 6:03 ` [PATCH 1/7] Fix double-free when creating more than one block in JIT debug info reader Simon Marchi
2019-12-13 6:03 ` [PATCH 6/7] jit: c++-ify gdb_block Simon Marchi
2019-12-13 7:54 ` Aktemur, Tankut Baris
2019-12-13 15:06 ` Simon Marchi
2019-12-13 15:11 ` Christian Biesinger via gdb-patches
2019-12-13 15:18 ` Simon Marchi
2019-12-13 20:57 ` Pedro Alves
2019-12-13 21:02 ` Simon Marchi [this message]
2019-12-13 22:20 ` Pedro Alves
2019-12-14 17:39 ` Simon Marchi
2019-12-13 6:03 ` [PATCH 3/7] jit: c++-ify gdb_symtab Simon Marchi
2019-12-13 21:01 ` Tom Tromey
2019-12-13 21:11 ` Simon Marchi
2019-12-13 6:18 ` [PATCH 4/7] jit: make gdb_symtab::blocks a vector Simon Marchi
2019-12-13 15:17 ` Christian Biesinger via gdb-patches
2019-12-13 16:02 ` Simon Marchi
2019-12-13 16:08 ` Christian Biesinger via gdb-patches
2019-12-13 16:14 ` Simon Marchi
2019-12-13 18:17 ` Christian Biesinger via gdb-patches
2019-12-13 22:14 ` Pedro Alves
2019-12-14 17:17 ` Simon Marchi
2019-12-13 21:19 ` [PATCH 0/7] Fix and cleanups in jit.c Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85f3026a-f05f-c357-d760-0b7c7cd90a02@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).