From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120933 invoked by alias); 10 Jan 2018 12:17:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120922 invoked by uid 89); 10 Jan 2018 12:17:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-wm0-f42.google.com Received: from mail-wm0-f42.google.com (HELO mail-wm0-f42.google.com) (74.125.82.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jan 2018 12:17:28 +0000 Received: by mail-wm0-f42.google.com with SMTP id f206so26622749wmf.5 for ; Wed, 10 Jan 2018 04:17:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=dZEhspDO5vn6xHybMwisfeMgRTCzncs8lUqMF3O/NO8=; b=fU8+g67RfEw2fW66k9ig1sG2Ey8fJaNWuE984J3PmV/SLGgrJOPAe3N5eMIQN90l3E 3FrPW9LTgsqdoUzA7PWe98s8r2g4EC4kGx/KEbwajH1SOPyf1oN714djBFWymNHnr0Pb /QD16bAAwhAubJW9LLLxfVRR2mFDunAgqdtT+0ZdYdJvusU5qwNenJLVUoOFFDZYkfeA 6wn4ewj6M+/scgKdJMXfyu6ZRNeeE0QcFr3PRccOp1ARpsRzuD++ZdAVroCowgscUaqy 4s1wkhzOIeLeJsQfQbloSQgdnpi81JjNpKtYMevMbt9YYiXlAh4aVui/+OqstBjeskHH k2Hw== X-Gm-Message-State: AKGB3mKujTG7exf34MemCZhfF0i8rhTLu0pdRXQrjIdnE5Da9TRQNqni aLcCI8JZPM6KbLZ7TQHIwkF3Ag== X-Google-Smtp-Source: ACJfBosv1/GZR3CTEt9bY04auOUEU7WgduPzNZ8eHHP7ZAqgvglQP2PmGwobjJyU/no7SIlxX5VHaA== X-Received: by 10.28.87.195 with SMTP id l186mr15463468wmb.27.1515586646317; Wed, 10 Jan 2018 04:17:26 -0800 (PST) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id a69sm14852723wma.25.2018.01.10.04.17.25 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 10 Jan 2018 04:17:25 -0800 (PST) From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 3/6] Allocate dwarf2_cu with new References: <20180106002621.21099-1-tom@tromey.com> <20180106002621.21099-4-tom@tromey.com> Date: Wed, 10 Jan 2018 12:17:00 -0000 In-Reply-To: <20180106002621.21099-4-tom@tromey.com> (Tom Tromey's message of "Fri, 5 Jan 2018 17:26:18 -0700") Message-ID: <861sixhprf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00196.txt.bz2 Tom Tromey writes: > /* Internal state when decoding a particular compilation unit. */ > struct dwarf2_cu > { > + dwarf2_cu (struct dwarf2_per_cu_data *per_cu); Add "explicit"? > + ~dwarf2_cu (); > + > + DISABLE_COPY_AND_ASSIGN (dwarf2_cu); > + > + void free_abbrev_table (); Move comments to dwarf2_free_abbrev_table here? --=20 Yao (=E9=BD=90=E5=B0=A7)