From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24773 invoked by alias); 8 Feb 2017 17:36:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24756 invoked by uid 89); 8 Feb 2017 17:36:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=regnum, register_status, ui_file, register_buffer X-HELO: mail-wm0-f51.google.com Received: from mail-wm0-f51.google.com (HELO mail-wm0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Feb 2017 17:36:38 +0000 Received: by mail-wm0-f51.google.com with SMTP id r141so195767871wmg.1 for ; Wed, 08 Feb 2017 09:36:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=TQDeWkB2eGCHtACOZLxBl6dC68K298h56fAdCgc/shY=; b=II6sOBny2+9LBCdG/ZqnnFGI791eLFzPCn82q7uA76k89waaMdtaxIVuQBE015aD77 bMDtGNJvQwmNle+Lj/wRmMYZW0Wm8VlH8Fzh7cjVc6kYUhil5eDU1dS2GN/ZQMj44isO e9YyviwTGgl52diBiCOx04V6SIX1b9yQGdpkItXDKaiXMkFwUQbwLQn2RlPe6voV/zG2 /deWbRgCDY8+kJa3YjHZYK/kU8PQ1dJHVT36Cwlw5tkVMmnja9W+IKbTXNLj3z6J82UU vrXMF2pO2Z+/fRv4x15YdgN/wDLYBQE6SngoaXPfB0tyvdpbWT/lzo+4AEm8HLQRCLgT Ri3A== X-Gm-Message-State: AIkVDXLQQxZSmS4o2ihNOv3JgpJyW5sMH+r0aP2yZRC+LUcdjIdr9htnJV7UxrfL3wJopw== X-Received: by 10.223.129.163 with SMTP id 32mr19056948wra.140.1486575395935; Wed, 08 Feb 2017 09:36:35 -0800 (PST) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id y65sm4459642wmb.5.2017.02.08.09.36.34 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 08 Feb 2017 09:36:35 -0800 (PST) From: Yao Qi To: Alan Hayward Cc: Pedro Alves , Joel Brobecker , "gdb-patches\@sourceware.org" , Subject: Re: [PATCH] Removal of uses of MAX_REGISTER_SIZE References: <45e3a5e1-a9aa-1bc0-5d08-526b89fc458e@redhat.com> <20170201124123.GA27498@E107787-LIN> <20170202094012.dge4r6rsl2skdrii@adacore.com> <20170203102819.GA11916@E107787-LIN> <25716edf-096e-20c5-4170-fb8ca04d897b@redhat.com> <0C6A0D51-4C49-4400-8C46-E77DD512DF56@arm.com> <20170203165022.GB11916@E107787-LIN> <1E0030CE-FB37-4821-AA53-9C6D1CC285C9@arm.com> <20170206152635.GE11916@E107787-LIN> <5F3D30AE-9A53-493A-B6DC-DF594C2FAB18@arm.com> Date: Wed, 08 Feb 2017 17:36:00 -0000 In-Reply-To: <5F3D30AE-9A53-493A-B6DC-DF594C2FAB18@arm.com> (Alan Hayward's message of "Tue, 7 Feb 2017 16:33:19 +0000") Message-ID: <861sv8pote.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00199.txt.bz2 Alan Hayward writes: > @@ -1279,7 +1335,7 @@ regcache_dump (struct regcache *regcache, struct ui= _file *file, > int footnote_register_offset =3D 0; > int footnote_register_type_name_null =3D 0; > long register_offset =3D 0; > - gdb_byte buf[MAX_REGISTER_SIZE]; > + std::vector buf (max_register_size (gdbarch)); > > #if 0 > fprintf_unfiltered (file, "nr_raw_registers %d\n", > @@ -1406,8 +1462,8 @@ regcache_dump (struct regcache *regcache, struct ui= _file *file, > fprintf_unfiltered (file, ""); > else > { > - regcache_raw_read (regcache, regnum, buf); > - print_hex_chars (file, buf, > + regcache_raw_update (regcache, regnum); > + print_hex_chars (file, register_buffer (regcache, regnum), > regcache->descr->sizeof_register[regnum], > gdbarch_byte_order (gdbarch)); > } > @@ -1422,13 +1478,13 @@ regcache_dump (struct regcache *regcache, struct = ui_file *file, > { > enum register_status status; > > - status =3D regcache_cooked_read (regcache, regnum, buf); > + status =3D regcache_cooked_read (regcache, regnum, buf.data ()); Can we use regcache_cooked_read_value so that we don't need buf at all. > if (status =3D=3D REG_UNKNOWN) > fprintf_unfiltered (file, ""); > else if (status =3D=3D REG_UNAVAILABLE) > fprintf_unfiltered (file, ""); > else > - print_hex_chars (file, buf, > + print_hex_chars (file, buf.data (), > regcache->descr->sizeof_register[regnum], > gdbarch_byte_order (gdbarch)); > } --=20 Yao (=E9=BD=90=E5=B0=A7)