From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66745 invoked by alias); 11 May 2016 11:58:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66735 invoked by uid 89); 11 May 2016 11:58:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1462 X-HELO: mail-pa0-f65.google.com Received: from mail-pa0-f65.google.com (HELO mail-pa0-f65.google.com) (209.85.220.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 May 2016 11:58:20 +0000 Received: by mail-pa0-f65.google.com with SMTP id i5so3463229pag.3 for ; Wed, 11 May 2016 04:58:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=olijuRVA0xEWhoOldYveGWkb5X0POh7Bqb/2Rvw+Tqs=; b=YK2zZlOy8Dvsp88o0KjOA/FEuFZk8GBn5ZW+Hk2PgYyL7SxOXgyaajRsSwOQo6/VDk wp/HSYsEiqd3MGvZOBI7QynWt6w3B5Xd1BdJ87EZkL/gMSPb5ys6HfCe9643KpTRdetr Mtb7e+Q63XAd6t39t3hllXYVcIidKfG9efbonxDVh9MnA1CS/kxTCXyIMZnVH8exkobK qBYuxk9iXGebwgsU3rNDRQwP7W9G1/6LG/AoBV7cB9uF17QTqCHGCA7p6cLJ92y/xTcH aAeTcdoAIyNwjQkYxv1mOXTqQh7Z4i8oWy32GUXXxHOeS3Sl9Spr+1kaxd5qQ5S3CCpc kd6A== X-Gm-Message-State: AOPr4FWue1qYKVx+Pf3gjcp8FOLuAwCONla2RtKVK3ju+am/pe9gAbccHz6PhVRpy+lfvQ== X-Received: by 10.66.26.225 with SMTP id o1mr4257254pag.79.1462967898582; Wed, 11 May 2016 04:58:18 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id e7sm11748803pfa.28.2016.05.11.04.58.15 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 11 May 2016 04:58:17 -0700 (PDT) From: Yao Qi To: Bernhard Heckel Cc: qiyaoltc@gmail.com, gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Fortran, typeprint: Fix wrong indentation when ptype nested structures. References: <1462889739-30359-1-git-send-email-bernhard.heckel@intel.com> <1462889739-30359-2-git-send-email-bernhard.heckel@intel.com> Date: Wed, 11 May 2016 11:58:00 -0000 In-Reply-To: <1462889739-30359-2-git-send-email-bernhard.heckel@intel.com> (Bernhard Heckel's message of "Tue, 10 May 2016 16:15:36 +0200") Message-ID: <861t58erhm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00178.txt.bz2 Bernhard Heckel writes: > diff --git a/gdb/testsuite/gdb.fortran/whatis_type.exp b/gdb/testsuite/gd= b.fortran/whatis_type.exp > index af897a6..edaf4fd 100644 > --- a/gdb/testsuite/gdb.fortran/whatis_type.exp > +++ b/gdb/testsuite/gdb.fortran/whatis_type.exp > @@ -39,15 +39,25 @@ set t1_i "$int :: t1_i" > set t1_r "$real :: t1_r" >=20=20 > gdb_test "whatis t1" \ > - "type =3D Type t1\r\n${t1_i}\r\n${t1_r}\r\nEnd Type t1" \ > - "whatis t1" > + [multi_line "type =3D Type t1" \ > + " $t1_i" \ > + " $t1_r" \ > + "End Type t1"] > + > gdb_test "whatis t1v" \ > - "type =3D Type t1\r\n${t1_i}\r\n${t1_r}\r\nEnd Type t1" \ > - "whatis t1v" > + [multi_line "type =3D Type t1" \ > + " $t1_i" \ > + " $t1_r" \ > + "End Type t1"] >=20=20 > gdb_test "ptype t1" \ > - "type =3D Type t1\r\n ${t1_i}\r\n ${t1_r}\r\nEnd Type t1" \ > - "ptype t1" > + [multi_line "type =3D Type t1" \ > + " $t1_i" \ > + " $t1_r" \ > + "End Type t1"] > + > gdb_test "ptype t1v" \ > - "type =3D Type t1\r\n ${t1_i}\r\n ${t1_r}\r\nEnd Type t1" \ > - "ptype t1v" > + [multi_line "type =3D Type t1" \ > + " $t1_i" \ > + " $t1_r" \ > + "End Type t1"] Could you please split your patch to two parts? The first part is to change test case using multi_line, and the second part is to adjust the indentation of expected output in the test. Looks your patch only affects the output of "whatis". --=20 Yao (=E9=BD=90=E5=B0=A7)