From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76303 invoked by alias); 15 Sep 2015 10:12:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76284 invoked by uid 89); 15 Sep 2015 10:12:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f169.google.com Received: from mail-wi0-f169.google.com (HELO mail-wi0-f169.google.com) (209.85.212.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 15 Sep 2015 10:12:14 +0000 Received: by wiclk2 with SMTP id lk2so20084943wic.1 for ; Tue, 15 Sep 2015 03:12:11 -0700 (PDT) X-Received: by 10.180.90.198 with SMTP id by6mr5996704wib.82.1442311931780; Tue, 15 Sep 2015 03:12:11 -0700 (PDT) Received: from E107787-LIN ([195.154.84.196]) by smtp.gmail.com with ESMTPSA id ww8sm20259193wjb.4.2015.09.15.03.12.11 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Tue, 15 Sep 2015 03:12:11 -0700 (PDT) From: Yao Qi To: Pierre Langlois Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/8] [AArch64] Make aarch64_decode_adrp handle both ADR and ADRP instructions References: <1442230282-20751-1-git-send-email-pierre.langlois@arm.com> <1442230282-20751-4-git-send-email-pierre.langlois@arm.com> Date: Tue, 15 Sep 2015 10:12:00 -0000 In-Reply-To: <1442230282-20751-4-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Mon, 14 Sep 2015 12:31:17 +0100") Message-ID: <861te03say.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00310.txt.bz2 Pierre Langlois writes: > gdb/ChangeLog: > > * aarch64-tdep.c (aarch64_analyze_prologue): New is_adrp > variable. Call aarch64_decode_adr instead of > aarch64_decode_adrp. > * arch/aarch64-insn.h (aarch64_decode_adrp): Delete. > (aarch64_decode_adr): New function declaration. > * arch/aarch64-insn.c (aarch64_decode_adrp): Delete. > (aarch64_decode_adr): New function, factored out from > aarch64_decode_adrp to decode both adr and adrp instructions. Looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)