From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 122E1384AB5B for ; Mon, 22 Apr 2024 19:44:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 122E1384AB5B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 122E1384AB5B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713815087; cv=none; b=Zy2fjln7U6Lo3EefWjVJYKtwTBN7cR6fkFikW8YznCD23//G/LpDWI1FfnGk78WgzTwnokxWK7Ja65CxwTD13dKWvi8Is5YHU6JCWB7bhUfa53zZO91kkewstBkWF4uVFWKGbpY5PYhyZ44I1Kn4DUMF9L27GPMfOWbd3QQp2cs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713815087; c=relaxed/simple; bh=cnnv8odzEFFqGbExEpatkchc3JIKtTLcfWUppXI4Bvg=; h=DKIM-Signature:Date:Message-Id:From:To:Subject:MIME-version; b=cf+lxH2swSxXkmUcErnqNb2JU0sYPGJwPtc2UarCTJrEXpeiYm9yXib00VOwTquplwfGZa8J7b8d6Ro7LesgDbPqLwxkGNgYeb335TuYJJQJF5CDWmVhQ41JGsqFzSyuIExAkv3nuy3uPmlff8G9Utmc3unK2Oy2b5OwxuSUbaA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryzam-0008NY-QN; Mon, 22 Apr 2024 15:44:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=VFb+LrUjSreYuhcYjEYomC8z57KVVOB4ibvbV4ShTKw=; b=PjQPsYuGG2UgujFcLc6+ hlI+ajaSbuw0la+ifLNxXczaPg8Z9mk4K7Wr8DFHGG1ocWaXQeAMdP53xmhQx+3AEvMAkriHvDeqU iaohal8Pucx+NKnDoQgMvWOh2DdFnuh7j0U6UiELzdZIjpv5yzU2jO2hvrnFKkVxa9Jbfcv1TAmVU F5kOAa1jyxSGtPZFvWhPQAE+WKVFV0wfgRoSGE8i15GKKEGNl2m9INuQ/gKAE43lha52lB3sHO2Fk ft2pcV2Ms7OxqagzErFezQG+t/COUMlNHL3bC/HAUhM7TXs2b5QzkCcaH7rSKuKmqsy9jORqA94GM NHPSpxImAytJlw==; Date: Mon, 22 Apr 2024 22:44:39 +0300 Message-Id: <8634rd5gig.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves Cc: gdb-patches@sourceware.org, jimb@codesourcery.com, mike_wrighton@mentor.com, nathan@codesourcery.com, abidh@codesourcery.com In-Reply-To: (message from Pedro Alves on Mon, 22 Apr 2024 20:01:17 +0100) Subject: Re: [PATCH 01/12] Document conventions for describing packet syntax References: <20240419151342.1592474-1-pedro@palves.net> <20240419151342.1592474-2-pedro@palves.net> <867cgtbcih.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Mon, 22 Apr 2024 20:01:17 +0100 > Cc: gdb-patches@sourceware.org, jimb@codesourcery.com, > mike_wrighton@mentor.com, nathan@codesourcery.com, abidh@codesourcery.com > From: Pedro Alves > > >> +We place optional portions of a packet in @r{[}square brackets@r{]}; > > > > This should be in @samp, otherwise the @r parts are redundant and > > won't have any effect. > > > > Hmm, if I wrap that in @samp, then it renders as: > > We place optional portions of a packet in '[square brackets]'; for example, a template like ‘c [addr]’ describes a packet beginning with the single ASCII character ‘c’, possibly followed by an addr. > > Those '' around [square brackets] seem off to me there. The original author must have wanted the > rendered text without the single quotes too, since they didn't use @samp and they certainly > looked at the rendered output back then. So given @r are nops, I think we should just remove them. Removing @r is fine by me, thanks.