From: Eli Zaretskii <eliz@gnu.org>
To: Gustavo Romero <gustavo.romero@linaro.org>
Cc: gdb-patches@sourceware.org, luis.machado@arm.com,
thiago.bauermann@linaro.org, tom@tromey.com
Subject: Re: [PATCH v4 8/8] gdb: Document qIsAddressTagged packet
Date: Wed, 17 Apr 2024 15:09:36 +0300 [thread overview]
Message-ID: <8634rki41r.fsf@gnu.org> (raw)
In-Reply-To: <e0790dea-3323-c426-ac2c-5a0b459bb188@linaro.org> (message from Gustavo Romero on Tue, 16 Apr 2024 20:10:43 -0300)
> Cc: gdb-patches@sourceware.org, luis.machado@arm.com,
> thiago.bauermann@linaro.org, tom@tromey.com
> From: Gustavo Romero <gustavo.romero@linaro.org>
> Date: Tue, 16 Apr 2024 20:10:43 -0300
>
> Hi Eli,
>
> Thanks a lot for the review. I just have one question.
>
> >> +@item E @var{nn}
> >> +An error occurred. This means that address could not be checked for some
> >> +reason.
> >
> > Here "nn" is the error value, right? If so, I suggest to say
> >
> > @item E @var{nn}
> > An error occurred whose code is @var{nn}.
>
> Do you mean remove the "This means that address could not be checked for some reason."
> text completely or just s/An error occurred/An error occurred whose code is @var{nn}/?
The latter.
next prev parent reply other threads:[~2024-04-17 12:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 14:07 [PATCH v4 0/8] Add another way to check tagged addresses on remote targets Gustavo Romero
2024-04-16 14:07 ` [PATCH v4 1/8] gdb: aarch64: Remove MTE address checking from get_memtag Gustavo Romero
2024-04-16 14:07 ` [PATCH v4 2/8] gdb: aarch64: Move MTE address check out of set_memtag Gustavo Romero
2024-04-16 16:30 ` Luis Machado
2024-04-16 14:07 ` [PATCH v4 3/8] gdb: aarch64: Remove MTE address checking from memtag_matches_p Gustavo Romero
2024-04-16 14:07 ` [PATCH v4 4/8] gdb: Use passed gdbarch instead of calling current_inferior Gustavo Romero
2024-04-16 14:07 ` [PATCH v4 5/8] gdb: Introduce is_address_tagged target hook Gustavo Romero
2024-04-17 9:22 ` Luis Machado
2024-04-16 14:07 ` [PATCH v4 6/8] gdb: Add qIsAddressTagged packet Gustavo Romero
2024-04-16 18:04 ` Luis Machado
2024-04-17 20:57 ` Gustavo Romero
2024-04-16 14:07 ` [PATCH v4 7/8] gdb/testsuite: Add unittest for " Gustavo Romero
2024-04-17 9:38 ` Luis Machado
2024-04-17 19:03 ` Gustavo Romero
2024-04-17 19:11 ` Gustavo Romero
2024-04-16 14:07 ` [PATCH v4 8/8] gdb: Document " Gustavo Romero
2024-04-16 14:34 ` Eli Zaretskii
2024-04-16 23:10 ` Gustavo Romero
2024-04-17 12:09 ` Eli Zaretskii [this message]
2024-04-17 18:21 ` Gustavo Romero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634rki41r.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gustavo.romero@linaro.org \
--cc=luis.machado@arm.com \
--cc=thiago.bauermann@linaro.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).