From: Yao Qi <qiyaoltc@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: ping#2: [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones
Date: Mon, 30 Oct 2017 11:31:00 -0000 [thread overview]
Message-ID: <863760zxcg.fsf@gmail.com> (raw)
In-Reply-To: <20171018195237.GA19714@host1.jankratochvil.net> (Jan Kratochvil's message of "Wed, 18 Oct 2017 21:52:37 +0200")
Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Forget to mention in my last email,
> +// TRUE means this kernel has fixed PR external/20207.
> +// Fixed kernel supports any contiguous range of bits in 8-bit byte
> +// DR_CONTROL_MASK. Buggy kernel supports only 0x01, 0x03, 0x0f and 0xff.
> +static bool have_any_contiguous (true);
We still use /* */ for multi-line comments...
> +
> +// Return starting byte (0..7) of a watchpoint encoded by CTRL.
> +
... and function comment.
> +unsigned int
> +aarch64_watchpoint_offset (unsigned int ctrl)
> +{
> + uint8_t mask = DR_CONTROL_MASK (ctrl);
> + unsigned retval;
> +
> + // Shift out bottom zeroes.
> + for (retval = 0; mask && (mask & 1) == 0; ++retval)
> + mask >>= 1;
> +
> + return retval;
> +}
> +
--
Yao (齐尧)
prev parent reply other threads:[~2017-10-30 11:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 21:08 Jan Kratochvil
2017-06-19 13:43 ` ping: " Jan Kratochvil
2017-06-19 13:44 ` Jan Kratochvil
2017-10-18 19:52 ` ping#2: " Jan Kratochvil
2017-10-30 11:27 ` Yao Qi
2017-11-03 22:04 ` Jan Kratochvil
2018-03-21 19:03 ` ping: " Jan Kratochvil
2018-04-20 14:49 ` Pedro Alves
2018-04-20 14:56 ` Pedro Alves
2018-04-20 15:54 ` Eli Zaretskii
2018-04-20 15:59 ` Pedro Alves
2018-04-26 20:12 ` Jan Kratochvil
2018-05-01 23:03 ` Jan Kratochvil
2018-05-01 23:06 ` Jan Kratochvil
2018-05-02 14:50 ` Eli Zaretskii
2018-05-03 9:16 ` Jan Kratochvil
2018-05-03 9:18 ` Jan Kratochvil
2018-05-04 16:40 ` Pedro Alves
2018-05-04 20:30 ` [commit] " Jan Kratochvil
2018-05-04 20:47 ` Pedro Alves
2018-05-07 8:03 ` Omair Javaid
2018-05-07 8:36 ` Jan Kratochvil
2018-05-08 12:08 ` [patch] " Ulrich Weigand
2018-05-08 12:27 ` [obv] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests [Re: [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones] Jan Kratochvil
2018-05-08 12:45 ` [obv] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests [Re: [patch] aarch64: PR 19806: watchpoints: false negatives + PR Ulrich Weigand
2017-10-30 11:31 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863760zxcg.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).