From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-127599-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 118655 invoked by alias); 19 Nov 2015 11:52:31 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 118641 invoked by uid 89); 19 Nov 2015 11:52:30 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-pa0-f52.google.com
Received: from mail-pa0-f52.google.com (HELO mail-pa0-f52.google.com) (209.85.220.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 19 Nov 2015 11:52:30 +0000
Received: by pacej9 with SMTP id ej9so79226282pac.2        for <gdb-patches@sourceware.org>; Thu, 19 Nov 2015 03:52:28 -0800 (PST)
X-Received: by 10.66.253.135 with SMTP id aa7mr10015607pad.14.1447933948209;        Thu, 19 Nov 2015 03:52:28 -0800 (PST)
Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137])        by smtp.gmail.com with ESMTPSA id dw5sm10264258pbb.3.2015.11.19.03.52.25        (version=TLS1_2 cipher=AES128-SHA bits=128/128);        Thu, 19 Nov 2015 03:52:27 -0800 (PST)
From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>,  <qiyaoltc@gmail.com>
Subject: Re: [PATCH] Fix length calculation in aarch64_linux_set_debug_regs
References: <1446475684-31936-1-git-send-email-simon.marchi@ericsson.com>
Date: Thu, 19 Nov 2015 11:52:00 -0000
In-Reply-To: <1446475684-31936-1-git-send-email-simon.marchi@ericsson.com>	(Simon Marchi's message of "Mon, 2 Nov 2015 09:48:04 -0500")
Message-ID: <8637w21a14.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2015-11/txt/msg00384.txt.bz2

Simon Marchi <simon.marchi@ericsson.com> writes:

> correct.  Instead, it can be computed simply with:
>
>   offsetof (struct user_hwdebug_state, dbg_regs) + count * sizeof (regs.d=
bg_reg[0]);
>
> Does it make sense?
>
> gdb/ChangeLog:
>
> 	* nat/aarch64-linux-hw-point.c (aarch64_linux_set_debug_regs): Fix
> 	iov_len computation.

The old code is correct, but in order to make G++ happy, we still need
this patch, is that right?

--=20
Yao (=E9=BD=90=E5=B0=A7)