From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 143E43854830 for ; Tue, 7 Mar 2023 16:14:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 143E43854830 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8424B1E128; Tue, 7 Mar 2023 11:14:08 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1678205648; bh=IK9I5Ucc10uSSNaPvpHnGN56BaQ7e6aoGz2FC7FU2G8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ebunRFeKSmyx066gMDq1rGF5POJD/OYjN5qopk2JIdQeph0iweSNyRfh6KLRjTn9m m1D9UNR/j42aeBWQ+ncbISdWyLfijgDRJoQqBWpgfBvFr7+kqfm7QXWTGxT59ISJpt IajBTG5U7YjF+cwkYcxPrwh2oN7EIxRy4ok3D7qM= Message-ID: <8641490b-862c-0174-8949-643ebe794ff1@simark.ca> Date: Tue, 7 Mar 2023 11:14:08 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] gdb: Fix GDB_AC_CHECK_BFD macro regression Content-Language: en-US To: "Jose E. Marchesi" Cc: Richard Purdie , gdb-patches@sourceware.org, Simon Marchi References: <20230307142150.2553808-1-richard.purdie@linuxfoundation.org> <62a25833-16a5-269e-4921-a15e1080c369@simark.ca> <87ttywimma.fsf@oracle.com> From: Simon Marchi In-Reply-To: <87ttywimma.fsf@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_LOTSOFHASH,NICE_REPLY_A,SCC_5_SHORT_WORD_LINES,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/7/23 10:53, Jose E. Marchesi via Gdb-patches wrote: > >> On 3/7/23 09:21, Richard Purdie via Gdb-patches wrote: >>> Commit 5218fa9e8937b007d554f1e01c2e4ecdb9b7e271, "gdb: use libtool in >>> GDB_AC_CHECK_BFD" dropped passing in existing LDFLAGS. In our environment, >>> this caused the configure check "checking for ELF support in BFD" to stop >>> working causing build failures as we need our LDFLAGS to be used for >>> correct linking. >>> >>> That change also meant the code failed to match the comments. Add back the >>> missing LDFLAGS preservation, fix our builds and match the comment. >>> >>> Signed-off-by: Richard Purdie >>> --- >>> gdb/acinclude.m4 | 2 +- >>> gdb/configure | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4 >>> index 05106df8ee6..173e40b440a 100644 >>> --- a/gdb/acinclude.m4 >>> +++ b/gdb/acinclude.m4 >>> @@ -234,7 +234,7 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [ >>> # points somewhere with bfd, with -I/foo/lib and -L/foo/lib. We >>> # always want our bfd. >>> CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS" >>> - LDFLAGS="-L../bfd -L../libiberty" >>> + LDFLAGS="-L../bfd -L../libiberty $LDFLAGS" >>> intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` >>> LIBS="-lbfd -liberty $intl $LIBS" >>> CC="./libtool --quiet --mode=link $CC" >>> diff --git a/gdb/configure b/gdb/configure >>> index 017ec05e4b7..18328fe5d42 100755 >>> --- a/gdb/configure >>> +++ b/gdb/configure >>> @@ -28323,7 +28323,7 @@ fi >>> # points somewhere with bfd, with -I/foo/lib and -L/foo/lib. We >>> # always want our bfd. >>> CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS" >>> - LDFLAGS="-L../bfd -L../libiberty" >>> + LDFLAGS="-L../bfd -L../libiberty $LDFLAGS" >>> intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` >>> LIBS="-lbfd -liberty $intl $LIBS" >>> CC="./libtool --quiet --mode=link $CC" >> >> This LGTM, but just to be sure, let's wait for Jose to confirm. > > LGTM as well. > Thanks. Running autoreconf, I see one more hunk in configure. I amended the patch and pushed it: >From 5fc6b6d44cd63651c2902cbfc5b9734a55aaa617 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Tue, 7 Mar 2023 14:21:50 +0000 Subject: [PATCH] gdb: Fix GDB_AC_CHECK_BFD macro regression Commit 5218fa9e8937b007d554f1e01c2e4ecdb9b7e271, "gdb: use libtool in GDB_AC_CHECK_BFD" dropped passing in existing LDFLAGS. In our environment, this caused the configure check "checking for ELF support in BFD" to stop working causing build failures as we need our LDFLAGS to be used for correct linking. That change also meant the code failed to match the comments. Add back the missing LDFLAGS preservation, fix our builds and match the comment. Signed-off-by: Richard Purdie Change-Id: Ie91509116fab29f95b9db1ff0b6ddc280d460112 Approved-By: Simon Marchi Reviewed-By: Jose E. Marchesi --- gdb/acinclude.m4 | 2 +- gdb/configure | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4 index 05106df8ee62..173e40b440af 100644 --- a/gdb/acinclude.m4 +++ b/gdb/acinclude.m4 @@ -234,7 +234,7 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [ # points somewhere with bfd, with -I/foo/lib and -L/foo/lib. We # always want our bfd. CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS" - LDFLAGS="-L../bfd -L../libiberty" + LDFLAGS="-L../bfd -L../libiberty $LDFLAGS" intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` LIBS="-lbfd -liberty $intl $LIBS" CC="./libtool --quiet --mode=link $CC" diff --git a/gdb/configure b/gdb/configure index 017ec05e4b71..5bb2a0795e59 100755 --- a/gdb/configure +++ b/gdb/configure @@ -28206,7 +28206,7 @@ WIN32LIBS="$WIN32LIBS $WIN32APILIBS" # points somewhere with bfd, with -I/foo/lib and -L/foo/lib. We # always want our bfd. CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS" - LDFLAGS="-L../bfd -L../libiberty" + LDFLAGS="-L../bfd -L../libiberty $LDFLAGS" intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` LIBS="-lbfd -liberty $intl $LIBS" CC="./libtool --quiet --mode=link $CC" @@ -28323,7 +28323,7 @@ fi # points somewhere with bfd, with -I/foo/lib and -L/foo/lib. We # always want our bfd. CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS" - LDFLAGS="-L../bfd -L../libiberty" + LDFLAGS="-L../bfd -L../libiberty $LDFLAGS" intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` LIBS="-lbfd -liberty $intl $LIBS" CC="./libtool --quiet --mode=link $CC" base-commit: 2eb2613519ae444493c301be1c37901c8a528c40 -- 2.39.2