From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 11C2E384AB7E for ; Fri, 19 Apr 2024 15:37:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11C2E384AB7E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 11C2E384AB7E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713541077; cv=none; b=GTvntit8t5SMlw9ZsGFboKXeDIRp6CEK/icQ/ncHcnK2dkSpwq/sCLN588ksO+CI+/jFIbES2fwaiWAf7E6hBUEdzf6jBmJ3SOiLl6dgRBNWunKRjNyUuJ6Hgv4qaQr59+MedrHhyQGma/cK1uptjB62rWKu3bLXiVGov9uGHMs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713541077; c=relaxed/simple; bh=z1ym/5ot01qlk6I7CFHhbeaWQU/aga9NDyNJ7YdfBaU=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=heO0yjhL6SSkbgL+oFTWKPBnfuVTvlYlxRnyPxAqZ15IOUkXi+j7KrDJh4vvl4uwQIXZhy31jWFujcn88PXWvUCH2P7boPK5FCWf46lWxBh9MX7BFlDOZ5iKPNL5KgjLC+yR3MKrKcZfZYw5OSSY1FU/2Im+Q0oOONvypQw5hKI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxqJG-0005dZ-KF; Fri, 19 Apr 2024 11:37:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZtSAr82KzHm0fMwcFev+mRY19Eg0BrKi8qQRITvYUds=; b=sUOD9PD4fqgv WvlHhgpG13ra8KcbACnhq6d8o6D5pPMDLZ03nmxjyHgqrXbZtx5R9XntctTnu2suL42Jfhxf6cIhY IHIajLJDpYGNu68azg84B2gGB6feJVIH6RJcnjVF/XRLIB/Z7NjhXKOTXBsHpK4CTa+XOXdLnjWqy 42OKurD1aj+Jonh9s7oMyGAD1TlNc2i1fmHzS1nhEgeeSaHxuQUDf35qKDHvlmjr9g7KWPSyYpv9Y bydVto1+ESodkbFMfguXk/7CR+xLF7nm42b9QCMdDABOo3G5WYDbph2whdUjHkxG62ZyG/czm9LhS Tf364tK3WaViIY+WvSklvQ==; Date: Fri, 19 Apr 2024 18:37:51 +0300 Message-Id: <864jbxbbxs.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves Cc: gdb-patches@sourceware.org, jimb@codesourcery.com, mike_wrighton@mentor.com, nathan@codesourcery.com, abidh@codesourcery.com In-Reply-To: <20240419151342.1592474-4-pedro@palves.net> (message from Pedro Alves on Fri, 19 Apr 2024 16:13:33 +0100) Subject: Re: [PATCH 03/12] Document "E.MESSAGE" RSP errors References: <20240419151342.1592474-1-pedro@palves.net> <20240419151342.1592474-4-pedro@palves.net> X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Pedro Alves > Cc: Jim Blandy , > Mike Wrighton , > Nathan Sidwell , > Hafiz Abid Qadeer > Date: Fri, 19 Apr 2024 16:13:33 +0100 > > For many years, GDB has accepted a "E.MESSAGE" error reponse, in > addition to "E NN". For many packets, GDB strips the "E." before > giving the error message to the user. For others, GDB does not strip > the "E.", but still understands that it is an error, as it starts with > "E", and either prints the whole string, or ignores it and just > mentions an error occured (same as for "E NN"). > > This has been the case for as long as I remember. Now that I check, I > see that it's been there since 2006 (commit a76d924dffcb, also here: > https://sourceware.org/pipermail/gdb-patches/2006-September/047286.html). > All along, I actually thought it was documented. Turns out it wasn't. > > This commit documents it, in the new "Standard Replies" section, near > where we document "E NN". > > The original version of this 3-patch documentation series was a single > CodeSourcery patch that documented the textual error as > "E.NAME.MESSAGE", with MESSAGE being 8-bit binary encoded. But I > think the ship has sailed for that. GDBserver has been sending error > messages with more than one "." for a long while, and with no binary > encoding. Still, I've preserved the "Co-Authored-By" list of the > original larger patch. > > Change-Id: Ie4fee3d00d82ede39e439bf162e8cb7485532fd8 > Co-Authored-By: Jim Blandy > Co-Authored-By: Mike Wrighton > Co-Authored-By: Nathan Sidwell > Co-Authored-By: Hafiz Abid Qadeer > --- > gdb/doc/gdb.texinfo | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 57260a5b2fa..d6184d52841 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -42557,6 +42557,10 @@ number. In almost all cases, the protocol does not specify the > meaning of the error numbers; @value{GDBN} usually ignores the > numbers, or displays them to the user without further interpretation. > > +@item @samp{E.@var{message}} > +An error has occurred; @var{message} is the textual error message, > +encoded in @sc{ascii}. > + > @end table > > @node Packets This is OK, thanks. Approved-By: Eli Zaretskii