From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76030 invoked by alias); 16 Nov 2017 09:17:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75781 invoked by uid 89); 16 Nov 2017 09:17:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=HX-Received:Thu, H*r:sk:static. X-HELO: mail-wm0-f41.google.com Received: from mail-wm0-f41.google.com (HELO mail-wm0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Nov 2017 09:17:28 +0000 Received: by mail-wm0-f41.google.com with SMTP id z3so8111272wme.5 for ; Thu, 16 Nov 2017 01:17:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Kp9ETDHjeXGQ26jEr0egR3NrC+1/s3r+vUTC5DioLok=; b=K4GIIfq17exoXvznXpsInbnJSMGtjkJYOf8Jt9zRD57wibT3kdX6xJynASs10b5l4h QCAfGlq0fEGUiaK4D8T++piII5b3ZaIq/y6Y/XnQ9PQbc3rzHYB0vReYx6Kod9IgUXyH 9zkTYqa3KXGTyEZAMUnhswtes/PlTaT24DJpL7J5LOG37NSVhBHPSrgaV9qpHXIBls7N l2xaAHmCGzn6ZFeJNUSCqCeq0tt4HMgq9wRfxORKLz/Bw6bXDu87EN9FTFJBLAamHSE1 ecrzK5EBbWijcY6y2Js5uz71Hpudl8t2DJG5ZrFHynj6/FzqrEnBmcJ7DJ07as0Nr2vu fGBg== X-Gm-Message-State: AJaThX4RvJHv1SHjw6390Rz8yPrPjgYn56UV/vlUKfTnBaBEsNQFlRcI KjZboZeBeJLzRdDF54S8M854TA== X-Google-Smtp-Source: AGs4zMZM1vi7chbB7VMFZSKqqtqGy1xm6rGYSWhVxsZG4qF3it29sKwdyUiZ/ppJ4yIQ/XijlejYdQ== X-Received: by 10.28.108.3 with SMTP id h3mr870544wmc.129.1510823845514; Thu, 16 Nov 2017 01:17:25 -0800 (PST) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id y15sm2159370wrc.96.2017.11.16.01.17.24 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 16 Nov 2017 01:17:25 -0800 (PST) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH] Allow osabi to be optional in target descriptors References: Date: Thu, 16 Nov 2017 09:17:00 -0000 In-Reply-To: (Alan Hayward's message of "Thu, 16 Nov 2017 08:09:39 +0000") Message-ID: <864lputwf1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00301.txt.bz2 Alan Hayward writes: Patch is good to me, some nits on commit log and code, > Osabi is an option field in target descriptors, according to: s/target descriptors/target descriptions/ > https://sourceware.org/gdb/current/onlinedocs/gdb/Target-Description-Form= at.html > > However, removing the osabi field from the i386 and amd64 target descript= ors Likewise. > > The following patch fixes this error. > > Tested with gdbserver on x86 and also on aarch64 with my target descripto= r patch. Likewise. > @@ -105,9 +104,12 @@ tdesc_get_features_xml (target_desc *tdesc) > buffer +=3D tdesc->arch; > buffer +=3D ""; > > - buffer +=3D ""; > - buffer +=3D tdesc->osabi; > - buffer +=3D ""; > + if (tdesc->osabi !=3D NULL) As we are in C++, I prefer nullptr. s/NULL/nullptr/ --=20 Yao (=E9=BD=90=E5=B0=A7)