From: Yao Qi <qiyaoltc@gmail.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Unset PROMPT_COMMAND before testing
Date: Thu, 22 Jun 2017 10:12:00 -0000 [thread overview]
Message-ID: <864lv8jpql.fsf@gmail.com> (raw)
In-Reply-To: <20170616231210.14867-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Sat, 17 Jun 2017 00:12:10 +0100")
Andrew Burgess <andrew.burgess@embecosm.com> writes:
> One of the GDB tests starts up a sub-shell and runs a few commands in
> it. In some cases, a users PROMPT_COMMAND might not work in the
> sub-shell GDB starts, which could cause the shell to emit unexpected
> warnings or errors, this in turn could cause tests to fail.
What is the concrete output in your case?
>
> The current example is gdb.base/batch-preserve-term-settings.exp, but
> there could be others in the future.
>
> I don't see any regressions with this patch, but I do now see 5
> additional passes on gdb.base/batch-preserve-term-settings.exp.
This patch sets the env for build rather than host, so it doesn't help
in remote host. Note that I don't think DejaGNU can set env in remote.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-06-22 10:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 23:12 Andrew Burgess
2017-06-22 10:12 ` Yao Qi [this message]
2017-06-22 19:14 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864lv8jpql.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).