From: Yao Qi <qiyaoltc@gmail.com>
To: Stafford Horne <shorne@gmail.com>
Cc: GDB patches <gdb-patches@sourceware.org>,
Openrisc <openrisc@lists.librecores.org>,
Franck Jullien <franck.jullien@gmail.com>
Subject: Re: [PATCH v7 1/4] gdb: Add OpenRISC or1k and or1knd target support
Date: Fri, 09 Jun 2017 10:10:00 -0000 [thread overview]
Message-ID: <864lvp5v4y.fsf@gmail.com> (raw)
In-Reply-To: <0d86778997b5aebf1301f883ef30833823a7dbd7.1496068645.git.shorne@gmail.com> (Stafford Horne's message of "Mon, 29 May 2017 23:48:23 +0900")
Stafford Horne <shorne@gmail.com> writes:
> diff --git a/gdb/features/or1k.xml b/gdb/features/or1k.xml
> new file mode 100644
> index 0000000..c138a02
> --- /dev/null
> +++ b/gdb/features/or1k.xml
> @@ -0,0 +1,12 @@
> +<?xml version="1.0"?>
> +<!-- Copyright (C) 2016 Free Software Foundation, Inc.
2017.
> +
> + set_gdbarch_print_insn (gdbarch, print_insn_or1k);
> +
Don't need to set gdbarch_print_insn, so remove this line. GDB will use
the default one, which selects the right disassembler in opcodes.
Otherwise, patch is good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-06-09 10:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 14:49 [PATCH v7 0/4] OpenRISC gdb port Stafford Horne
2017-05-29 14:49 ` [PATCH v7 3/4] gdb: testsuite: Add or1k tdesc-regs.exp test support Stafford Horne
2017-06-09 10:11 ` Yao Qi
2017-05-29 14:49 ` [PATCH v7 4/4] Add gdb for or1k build Stafford Horne
2017-05-29 14:49 ` [PATCH v7 1/4] gdb: Add OpenRISC or1k and or1knd target support Stafford Horne
2017-06-09 10:10 ` Yao Qi [this message]
2017-06-09 13:08 ` Stafford Horne
2017-06-10 8:11 ` Stafford Horne
2017-06-12 9:45 ` Yao Qi
2017-06-13 10:14 ` Stafford Horne
2017-05-29 14:49 ` [PATCH v7 2/4] gdb: testsuite: Add or1k l.nop instruction Stafford Horne
2017-06-09 10:11 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864lvp5v4y.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=franck.jullien@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=openrisc@lists.librecores.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).